Rework of subhire list

RIGS/models/events.py

@@ -17,7 +17,30 @@ from .utils import filter_by_pk
 from .finance import VatRate
 
 
-class EventManager(models.Manager):
+class BaseEventManager(models.Manager):
+    def event_search(self, q, start, end, status):
+        filt = Q()
+        if end:
+            filt &= Q(start_date__lte=end)
+        if start:
+            filt &= Q(start_date__gte=start)
+
+        objects = self.all()
+
+        if q:
+            objects = self.search(q)
+
+        if len(status) > 0:
+            filt &= Q(status__in=status)
+
+        qs = objects.filter(filt).order_by('-start_date')
+
+        # Preselect related for efficiency
+        qs.select_related('person', 'organisation', 'venue', 'mic')
+
+        return qs
+
+class EventManager(BaseEventManager):
     def current_events(self):
         events = self.filter(
             (models.Q(start_date__gte=timezone.now(), end_date__isnull=True, dry_hire=False) & ~models.Q(
@@ -390,7 +413,7 @@ class EventAuthorisation(models.Model, RevisionMixin):
         return f"{self.event.display_id} (requested by {self.sent_by.initials})"
 
 
-class SubhireManager(models.Manager):
+class SubhireManager(BaseEventManager):
     def current_events(self):
         events = self.exclude(status=BaseEvent.CANCELLED).filter(
             (models.Q(start_date__gte=timezone.now(), end_date__isnull=True)) |  # Starts after with no end
@@ -406,7 +429,6 @@ class SubhireManager(models.Manager):
         ).count()
         return event_count
 
-
 @reversion.register
 class Subhire(BaseEvent):
     insurance_value = models.DecimalField(max_digits=10, decimal_places=2) # TODO Validate if this is over notifiable threshold

RIGS/templates/event_archive.html

@@ -15,36 +15,7 @@
 {% endblock %}
 
 {% block content %}
-<div class="row">
-    <div class="col-sm-12 py-2">
-        <form class="form-inline" method="GET">
-            <div class="input-group mx-2">
-                <div class="input-group-prepend">
-                    <span class="input-group-text">Start</span>
-                </div>
-                <input type="date" name="start" id="start" value="{{ start|default_if_none:'' }}" placeholder="Start" class="form-control" />
-            </div>
-            <div class="input-group mx-2">
-                <div class="input-group-prepend">
-                    <span class="input-group-text">End</span>
-                </div>
-                <input type="date" name="end" id="end" value="{{ end|default_if_none:'' }}" placeholder="End" class="form-control" />
-            </div>
-            <div class="input-group mx-2">
-                <div class="input-group-prepend">
-                    <span class="input-group-text">Keyword</span>
-                </div>
-                <input type="search" name="q" placeholder="Keyword" value="{{ request.GET.q }}" class="form-control" />
-            </div>
-            <select class="selectpicker pr-3" multiple data-actions-box="true" data-none-selected-text="Status" data-actions-box="true" id="status" name="status">
-                {% for status in statuses %}
-                    <option value="{{status.0}}" {% if status.0|safe in request.GET|get_list:'status' %}selected=""{% endif %}>{{status.1}}</option>
-                {% endfor %}
-            </select>
-            {% button 'search' %}
-        </form>
-    </div>
-</div>
+{% include 'partials/archive_form.html' %}
 <div class="row">
     <div class="col-sm-12">
         {% with object_list as events %}

RIGS/templates/partials/archive_form.html

@@ -0,0 +1,32 @@
+{% load get_list from filters %}
+{% load button from filters %}
+<div class="row">
+    <div class="col-sm-12 py-2">
+        <form class="form-inline" method="GET">
+            <div class="input-group mx-2">
+                <div class="input-group-prepend">
+                    <span class="input-group-text">Start</span>
+                </div>
+                <input type="date" name="start" id="start" value="{{ start|default_if_none:'' }}" placeholder="Start" class="form-control" />
+            </div>
+            <div class="input-group mx-2">
+                <div class="input-group-prepend">
+                    <span class="input-group-text">End</span>
+                </div>
+                <input type="date" name="end" id="end" value="{{ end|default_if_none:'' }}" placeholder="End" class="form-control" />
+            </div>
+            <div class="input-group mx-2">
+                <div class="input-group-prepend">
+                    <span class="input-group-text">Keyword</span>
+                </div>
+                <input type="search" name="q" placeholder="Keyword" value="{{ request.GET.q }}" class="form-control" />
+            </div>
+            <select class="selectpicker pr-3" multiple data-actions-box="true" data-none-selected-text="Status" data-actions-box="true" id="status" name="status">
+                {% for status in statuses %}
+                    <option value="{{status.0}}" {% if status.0|safe in request.GET|get_list:'status' %}selected=""{% endif %}>{{status.1}}</option>
+                {% endfor %}
+            </select>
+            {% button 'search' %}
+        </form>
+    </div>
+</div>

RIGS/templates/partials/subhire_table.html

@@ -0,0 +1,84 @@
+{% load linked_name from filters %}
+{% load markdown_tags %}
+<div class="table-responsive">
+    <table class="table mb-0" id="event_table">
+        <thead>
+            <tr>
+                <th scope="col">#</th>
+                <th scope="col">Dates & Times</th>
+                <th scope="col">Hire Details</th>
+                <th scope="col">Associated Event(s)</th>
+                {% if perms.RIGS.subhire_finance %}
+                <th scope="col">Insurance Value</th>
+                {% endif %}
+            </tr>
+        </thead>
+        <tbody>
+        {% for event in events %}
+        <tr {% if event.cancelled %}style="opacity: 50% !important;"{% endif %} id="event_row">
+            <!---Number-->
+            <th scope="row" id="event_number">{{ event.display_id }}</th>
+            <!--Dates & Times-->
+            <td id="event_dates" style="text-align: justify;">
+                <span class="text-nowrap">Start: <strong>{{ event.start_date|date:"D d/m/Y" }}
+                {% if event.has_start_time %}
+                    {{ event.start_time|date:"H:i" }}
+                {% endif %}</strong>
+                </span>
+                {% if event.end_date %}
+                    <br>
+                    <span class="text-nowrap">End: {% if event.end_date != event.start_date %}<strong>{{ event.end_date|date:"D d/m/Y"  }}{% endif %}
+                    {% if event.has_end_time %}
+                       {{ event.end_time|date:"H:i" }}
+                    {% endif %}</strong>
+                    </span>
+                {% endif %}
+            </td>
+            <!---Details-->
+            <td id="event_details" class="w-100">
+                <h4>
+                    <a href="{{event.get_absolute_url}}">
+                        {{ event.name }}
+                    </a>
+                </h4>
+                <h5>
+                    Primary Contact: {{ event.person|linked_name }}
+                    {% if event.organisation %}
+                        ({{ event.organisation|linked_name }})
+                    {% endif %}
+                </h5>
+                {% if not event.cancelled and event.description %}
+                    <p>{{ event.description|markdown }}</p>
+                {% endif %}
+                {% include 'partials/event_status.html' %}
+            </td>
+            <td class="p-0 text-nowrap">
+                <ul class="list-group">
+                {% for event in event.events.all %}
+                <li class="list-group-item"><a href="{{event.get_absolute_url}}">{{ event }}</a></li>
+                {% endfor %}
+                </ul>
+            </td>
+            {% if perms.RIGS.subhire_finance %}
+            <td id="insurance_value" class="text-nowrap">
+                £{{ event.insurance_value }}
+            </td>
+            {% endif %}
+        </tr>
+        {% empty %}
+        <tr class="bg-warning">
+            <td colspan="4">No events found</td>
+        </tr>
+        {% endfor %}
+        </tbody>
+        <tfoot>
+            <tr>
+                <td></td>
+                <td></td>
+                <td></td>
+                <td>Total Value:</td>
+                <td>£{{ total_value }}</td>
+            </tr>
+        </tfoot>
+    </table>
+</div>

RIGS/templates/subhire_list.html

@@ -0,0 +1,27 @@
+{% extends 'base_rigs.html' %}
+{% load paginator from filters %}
+{% load static %}
+
+{% block css %}
+    {{ block.super }}
+    <link rel="stylesheet" href="{% static 'css/selects.css' %}"/>
+{% endblock %}
+
+{% block preload_js %}
+    {{ block.super }}
+    <script src="{% static 'js/selects.js' %}" async></script>
+{% endblock %}
+
+{% block content %}
+{% include 'partials/archive_form.html' %}
+<div class="row">
+    <div class="col-sm-12">
+        {% with object_list as events %}
+            {% include 'partials/subhire_table.html' %}
+        {% endwith %}
+    </div>
+</div>
+
+{% paginator %}
+
+{% endblock %}

RIGS/templatetags/filters.py

@@ -175,6 +175,9 @@ def namewithnotes(obj, url, autoescape=True):
     else:
         return obj.name
 
+@register.filter(needs_autoescape=True)
+def linked_name(object, autoescape=True):
+    return mark_safe(f"<a href='{object.get_absolute_url()}'>{object.name}</a>")
 
 @register.filter(needs_autoescape=True)
 def linkornone(target, namespace=None, autoescape=True):

RIGS/urls.py

@@ -74,7 +74,7 @@ urlpatterns = [
           name='subhire_create'),
     path('subhire/<int:pk>/edit', permission_required_with_403('RIGS.change_event')(views.SubhireEdit.as_view()),
           name='subhire_update'),
-    path('subhire/upcoming', login_required(views.SubhireList.as_view()),
+    path('subhire/list/', login_required(views.SubhireList.as_view()),
           name='subhire_list'),
 
      # Dashboards

RIGS/views/rigboard.py

@@ -204,27 +204,7 @@ class EventArchive(generic.ListView):
                                  "Muppet! Check the dates, it has been fixed for you.")
             start, end = end, start  # Stop the impending fail
 
-        filter = Q()
-        if end != "":
-            filter &= Q(start_date__lte=end)
-        if start:
-            filter &= Q(start_date__gte=start)
-
-        q = self.request.GET.get('q', "")
-        objects = self.model.objects.all()
-
-        if q:
-            objects = self.model.objects.search(q)
-
-        status = self.request.GET.getlist('status', "")
-
-        if len(status) > 0:
-            filter &= Q(status__in=status)
-
-        qs = objects.filter(filter).order_by('-start_date')
-
-        # Preselect related for efficiency
-        qs.select_related('person', 'organisation', 'venue', 'mic')
+        qs = self.model.objects.event_search(self.request.GET.get('q', None), start, end, self.request.GET.get('status', ""))
 
         if not qs.exists():
             messages.add_message(self.request, messages.WARNING, "No events have been found matching those criteria.")

RIGS/views/subhire.py

@@ -1,7 +1,9 @@
 from django.urls import reverse_lazy
 from django.views import generic
+from django.db.models import Sum
 from PyRIGS.views import ModalURLMixin, get_related
 from RIGS import models, forms
+from RIGS.views import EventArchive
 
 
 class SubhireDetail(generic.DetailView, ModalURLMixin):
@@ -48,11 +50,13 @@ class SubhireEdit(generic.UpdateView):
         return reverse_lazy('subhire_detail', kwargs={'pk': self.object.pk})
 
 
-class SubhireList(generic.TemplateView):
-    template_name = 'rigboard.html'
+class SubhireList(EventArchive):
+    template_name = 'subhire_list.html'
+    model = models.Subhire
+    paginate_by = 25
 
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
-        context['events'] = models.Subhire.objects.current_events()
-        context['page_title'] = "Upcoming Subhire"
+        context['total_value'] = self.get_queryset().aggregate(sum=Sum('insurance_value'))['sum']
+        context['page_title'] = "Subhire List"
         return context