Minor fix for importer adding @nottingham.ac.uk to empty emails.

Small test case for email fixer to make sure that emails are fixed correctly.
This commit is contained in:
tomtom5152
2015-01-27 16:51:58 +00:00
parent 75f9d2ffc4
commit 1aff7bcadb
2 changed files with 44 additions and 10 deletions

View File

@@ -14,6 +14,13 @@ from RIGS import models
import reversion
from datetime import datetime
def fix_email(email):
if not (email is None or email is "") and ("@" not in email):
email += "@nottingham.ac.uk"
return email
def setup_cursor():
try:
cursor = connections['legacy'].cursor()
@@ -63,8 +70,7 @@ def import_people(delete=False):
resp = cursor.fetchall()
for row in resp:
email = row[3]
if (email is not None) and ("@" not in email):
email += "@nottingham.ac.uk"
fix_email(email)
notes = ""
if row[5] != "Normal":
@@ -256,14 +262,14 @@ def import_nonrigs(delete=False):
event.save()
def main():
# import_users()
# import_people()
# import_organisations()
# import_vat_rates()
# import_venues(True)
# import_rigs(False)
# import_eventitem(True)
import_nonrigs(True)
import_users()
import_people()
import_organisations()
import_vat_rates()
import_venues(False)
import_rigs(False)
import_eventitem(False)
import_nonrigs(False)
if __name__ == "__main__":

28
RIGS/importer_tests.py Normal file
View File

@@ -0,0 +1,28 @@
__author__ = 'ghost'
import unittest
from importer import fix_email
class EmailFixerTest(unittest.TestCase):
def test_correct(self):
e = fix_email("tom@ghost.uk.net")
self.assertEqual(e, "tom@ghost.uk.net")
def test_partial(self):
e = fix_email("psytp")
self.assertEqual(e, "psytp@nottingham.ac.uk")
def test_none(self):
old = None
new = fix_email(old)
self.assertEqual(old, new)
def test_empty(self):
old = ""
new = fix_email(old)
self.assertEqual(old, new)
if __name__ == '__main__':
unittest.main()