Create trigger_codeQL

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/ISSUE_TEMPLATE/report-trouble.md

@@ -7,6 +7,24 @@ assignees: ''
 
 ---
 
-## PLEASE NEVER PASTE YOUR ACCESS TOKEN INTO A GITHUB ISSUE AS IT MAY CONTAIN PRIVATE INFORMATION
+<!-- 
+# BEFORE OPENING A NEW ISSUE CHECK THE EXISTING ONES AND RUN DESTREAMER WITH THE -v/--verbose flag and paste down below the output
 
+# NEVER PASTE YOUR ACCESS TOKEN INTO A GITHUB ISSUE AS IT MAY CONTAIN PRIVATE INFORMATION
 When you paste in output from destreamer, locate your access token (it looks like this: `Authorization: Bearer eyJ....<a lot more base64 encoded text>.....`) and redact it.
+
+# Please fill the form below to give us some more info. 
+-->
+
+OS:
+
+Launch command used:
+
+
+<details>
+<summary>Verbose  log</summary>
+  
+```
+PASTE VERBOSE LOG HERE
+```
+</details>

.github/workflows/build.yaml

@@ -6,6 +6,9 @@ on:
     - 'README.md'
     branches:
     - master
+  pull_request:
+    branches:
+    - master
 
 jobs:
   build:
@@ -14,7 +17,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [8.x, 10.x, 12.x, 13.x]
+        node-version: [10.x, 12.x, 13.x]
 
     steps:
     - uses: actions/checkout@v1

.gitignore

@@ -9,3 +9,4 @@ node_modules
 videos
 release
 build
+yarn.lock

.vscode/settings.json

@@ -1,3 +1,4 @@
 {
-    "eslint.enable": true
+    "eslint.enable": true,
+    "typescript.tsdk": "node_modules\\typescript\\lib"
 }

README.md

@@ -1,6 +1,10 @@
-<a href="https://github.com/snobu/destreamer/actions">
+# This project is abandoned. It will probably not work anymore against your MS Stream tenant.
-  <img src="https://github.com/snobu/destreamer/workflows/Node%20CI/badge.svg" alt="CI build status" />
+
-</a>
+# A heartfelt thank you to all the contributors over the years. You are the real MVPs. 💖
+
+## Check out kylon's Sharedown for a SharePoint-backend implementation - https://github.com/kylon/Sharedown
+
+<hr>
 
 ![destreamer](assets/logo.png)
 
@@ -8,15 +12,16 @@ _(Alternative artwork proposals are welcome! Submit one through an Issue.)_
 
 # Saves Microsoft Stream videos for offline enjoyment
 
-### v2.1 Release, codename _Hammer of Dawn<sup>TM</sup>_
+### v2 Release, codename _Hammer of Dawn<sup>TM</sup>_
 
 This release would not have been possible without the code and time contributed by two distinguished developers: [@lukaarma](https://github.com/lukaarma) and [@kylon](https://github.com/kylon). Thank you!
 
-### Specialized vesions
+### Specialized versions
 
 - [Politecnico di Milano][polimi]: fork over at https://github.com/SamanFekri/destreamer
 - [Università di Pisa][unipi]: fork over at https://github.com/Guray00/destreamer-unipi
 - [Università della Calabria][unical]: fork over at https://github.com/peppelongo96/UnicalDown
+- [Università degli Studi di Parma][unipr]: fork over at https://github.com/vRuslan/destreamer-unipr
 
 ## What's new
 ### v2.2
@@ -35,7 +40,7 @@ Hopefully this doesn't break the end user agreement for Microsoft Stream. Since
 
 ## Prereqs
 
-- [**Node.js**][node]: You'll need Node.js version 8.0 or higher. A GitHub Action runs tests on all major Node versions on every commit. One caveat for Node 8, if you get a `Parse Error` with `code: HPE_HEADER_OVERFLOW` you're out of luck and you'll need to upgrade to Node 10+.
+- [**Node.js**][node]: You'll need Node.js version 8.0 or higher. A GitHub Action runs tests on all major Node versions on every commit. One caveat for Node 8, if you get a `Parse Error` with `code: HPE_HEADER_OVERFLOW` you're out of luck and you'll need to upgrade to Node 10+. PLEASE NOTE WE NO LONGER TEST BUILDS AGAINST NODE 8.x. YOU ARE ON YOUR OWN.
 - **npm**: usually comes with Node.js, type `npm` in your terminal to check for its presence
 - [**ffmpeg**][ffmpeg]: a recent version (year 2019 or above), in `$PATH` or in the same directory as this README file (project root).
 - [**git**][git]: one or more npm dependencies require git.
@@ -51,6 +56,29 @@ Note that destreamer won't run in an elevated (Administrator/root) shell. Runnin
 
 **WSL** (Windows Subsystem for Linux) is not supported as it can't easily pop up a browser window. It *may* work by installing an X Window server (like [Xming][xming]) and exporting the default display to it (`export DISPLAY=:0`) before running destreamer. See [this issue for more on WSL v1 and v2][wsl].
 
+## Can i plug in my own browser?
+
+Yes, yes you can. This may be useful if your main browser has some authentication plugins that are required for you to logon to your Microsoft Stream tenant.
+To use your own browser for the authentication part, locate the following snippet in `src/destreamer.ts` and `src/TokenCache.ts`:
+
+```typescript
+const browser: puppeteer.Browser = await puppeteer.launch({
+  executablePath: getPuppeteerChromiumPath(),
+  // …
+});
+```
+
+Navigate to `chrome://version` in the browser you want to plug in and copy executable path from there. Use double backslash for Windows.
+
+Now, change `executablePath` to reflect the path to your browser and profile (i.e. to use Microsoft Edge on Windows):
+```typescript
+        executablePath: 'C:\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe',
+```
+
+You can add `userDataDir` right after `executablePath` with the path to your browser profile (also shown in `chrome://version`) if you want that loaded as well.
+
+Remember to rebuild (`npm run build`) every time you change this configuration.
+
 ## How to build
 
 To build destreamer clone this repository, install dependencies and run the build script -
@@ -71,31 +99,35 @@ Options:
   --help                  Show help                                                                            [boolean]
   --version               Show version number                                                                  [boolean]
   --username, -u          The username used to log into Microsoft Stream (enabling this will fill in the email field for
-                          you)                                                                                  [string]
+                          you).                                                                                 [string]
-  --videoUrls, -i         List of video urls                                                                     [array]
+  --videoUrls, -i         List of urls to videos or Microsoft Stream groups.                                     [array]
   --inputFile, -f         Path to text file containing URLs and optionally outDirs. See the README for more on outDirs.
                                                                                                                 [string]
+  --outputDirectory, -o   The directory where destreamer will save your downloads.          [string] [default: "videos"]
   --outputTemplate, -t    The template for the title. See the README for more info.
                                                                 [string] [default: "{title} - {publishDate} {uniqueId}"]
-  --outputDirectory, -o   The directory where destreamer will save your downloads           [string] [default: "videos"]
+  --keepLoginCookies, -k  Let Chromium cache identity provider cookies so you can use "Remember me" during login.
-  --keepLoginCookies, -k  Let Chromium cache identity provider cookies so you can use "Remember me" during login
+                          Must be used every subsequent time you launch Destreamer if you want to log in automatically.
                                                                                               [boolean] [default: false]
-  --noExperiments, -x     Do not attempt to render video thumbnails in the console            [boolean] [default: false]
+  --noExperiments, -x     Do not attempt to render video thumbnails in the console.           [boolean] [default: false]
-  --simulate, -s          Disable video download and print metadata information to the console[boolean] [default: false]
+  --simulate, -s          Disable video download and print metadata information to the console.
-  --verbose, -v           Print additional information to the console (use this before opening an issue on GitHub)
                                                                                               [boolean] [default: false]
-  --closedCaptions, --cc  Check if closed captions are aviable and let the user choose which one to download (will not
+  --verbose, -v           Print additional information to the console (use this before opening an issue on GitHub).
-                          ask if only one aviable)                                            [boolean] [default: false]
+                                                                                              [boolean] [default: false]
-  --noCleanup, --nc       Do not delete the downloaded video file when an FFmpeg error occurs [boolean] [default: false]
+  --closedCaptions, --cc  Check if closed captions are available and let the user choose which one to download (will not
+                          ask if only one available).                                         [boolean] [default: false]
+  --noCleanup, --nc       Do not delete the downloaded video file when an FFmpeg error occurs.[boolean] [default: false]
   --vcodec                Re-encode video track. Specify FFmpeg codec (e.g. libx265) or set to "none" to disable video.
                                                                                               [string] [default: "copy"]
   --acodec                Re-encode audio track. Specify FFmpeg codec (e.g. libopus) or set to "none" to disable audio.
                                                                                               [string] [default: "copy"]
-  --format                Output container format (mkv, mp4, mov, anything that FFmpeg supports)
+  --format                Output container format (mkv, mp4, mov, anything that FFmpeg supports).
                                                                                                [string] [default: "mkv"]
-  --skip                  Skip download if file already exists                                [boolean] [default: false]
+  --skip                  Skip download if file already exists.                               [boolean] [default: false]
 ```
 
+- both --videoUrls and --inputFile also accept Microsoft Teams Groups url so if your Organization placed the videos you are interested in a group you can copy the link and Destreamer will download all the videos it can inside it! A group url looks like this https://web.microsoftstream.com/group/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
+
 - Passing `--username` is optional. It's there to make logging in faster (the username field will be populated automatically on the login form).
 
 - You can use an absolute path for `-o` (output directory), for example `/mnt/videos`.
@@ -140,13 +172,13 @@ These optional lines must start with white space(s).
 Usage -
 ```
 https://web.microsoftstream.com/video/xxxxxxxx-aaaa-xxxx-xxxx-xxxxxxxxxxxx
- -dir=videos/lessons/week1
+ -dir="videos/lessons/week1"
 https://web.microsoftstream.com/video/xxxxxxxx-aaaa-xxxx-xxxx-xxxxxxxxxxxx
-        -dir=videos/lessons/week2"
+ -dir="videos/lessons/week2"
 ```
 
 ### Title template
-The `-t` option allows users to input a template string for the output file names.
+The `-t` option allows user to specify a custom filename for the videos.
 
 You can use one or more of the following magic sequence which will get substituted at runtime. The magic sequence must be surrounded by curly brackets like this: `{title} {publishDate}`
 
@@ -158,8 +190,20 @@ You can use one or more of the following magic sequence which will get substitut
 - `authorEmail`: E-mail of video publisher
 - `uniqueId`: An _unique-enough_ ID generated from the video metadata
 
-Example -
+Examples -
 ```
+Input:
+    -t 'This is an example'
+
+Expected filename:
+    This is an example.mkv
+
+Input:
+    -t 'This is an example by {author}'
+
+Expected filename:
+    This is an example by lukaarma.mkv
+
 Input:
     -t '{title} - {duration} - {publishDate} - {publishTime} - {author} - {authorEmail} - {uniqueId}'
 
@@ -177,7 +221,15 @@ iTerm2 on a Mac -
 
 ![screenshot](assets/screenshot-mac.png)
 
-By default, downloads are saved under `videos/` unless specified by `-o` (output directory).
+By default, downloads are saved under project root `Destreamer/videos/` ( Not the system media Videos folder ), unless specified by `-o` (output directory).
+
+## KNOWN BUGS
+
+If you get a
+```
+[FATAL ERROR] Unknown error: exit code 4
+````
+when running destreamer, then make sure you're running a recent (post year 2019), stable version of **ffmpeg**.
 
 ## Contributing
 
@@ -196,3 +248,4 @@ Please open an [issue](https://github.com/snobu/destreamer/issues) and we'll loo
 [polimi]: https://www.polimi.it
 [unipi]: https://www.unipi.it/
 [unical]: https://www.unical.it/portale/
+[unipr]: https://www.unipr.it/

package.json

@@ -17,34 +17,34 @@
   "author": "snobu",
   "license": "MIT",
   "devDependencies": {
-    "@types/mocha": "^7.0.2",
+    "@types/mocha": "^8.0.4",
-    "@types/puppeteer": "^1.20.4",
+    "@types/puppeteer": "^5.4.0",
     "@types/readline-sync": "^1.4.3",
-    "@types/tmp": "^0.1.0",
+    "@types/tmp": "^0.2.0",
-    "@types/yargs": "^15.0.3",
+    "@types/yargs": "^15.0.11",
-    "@typescript-eslint/eslint-plugin": "^2.25.0",
+    "@typescript-eslint/eslint-plugin": "^4.9.0",
-    "@typescript-eslint/parser": "^2.25.0",
+    "@typescript-eslint/parser": "^4.9.0",
-    "eslint": "^6.8.0",
+    "eslint": "^7.14.0",
-    "mocha": "^7.1.1",
+    "mocha": "^8.2.1",
-    "tmp": "^0.1.0"
+    "tmp": "^0.2.1"
   },
   "dependencies": {
-    "@tedconf/fessonia": "^2.1.0",
+    "@tedconf/fessonia": "^2.1.2",
-    "@types/cli-progress": "^3.4.2",
+    "@types/cli-progress": "^3.8.0",
     "@types/jwt-decode": "^2.2.1",
-    "axios": "^0.19.2",
+    "axios": "^0.21.2",
-    "axios-retry": "^3.1.8",
+    "axios-retry": "^3.1.9",
-    "cli-progress": "^3.7.0",
+    "cli-progress": "^3.8.2",
     "colors": "^1.4.0",
     "is-elevated": "^3.0.0",
-    "iso8601-duration": "^1.2.0",
+    "iso8601-duration": "^1.3.0",
-    "jwt-decode": "^2.2.0",
+    "jwt-decode": "^3.1.2",
-    "puppeteer": "2.1.1",
+    "puppeteer": "5.5.0",
     "readline-sync": "^1.4.10",
     "sanitize-filename": "^1.6.3",
-    "terminal-image": "^1.0.1",
+    "terminal-image": "^1.2.1",
-    "typescript": "^3.8.3",
+    "typescript": "^4.1.2",
-    "winston": "^3.3.2",
+    "winston": "^3.3.3",
-    "yargs": "^15.0.3"
+    "yargs": "^16.1.1"
   }
 }

src/ApiClient.ts

@@ -34,6 +34,9 @@ export class ApiClient {
                     return true;
                 }
                 logger.warn(`Got HTTP code ${err?.response?.status ?? undefined}. Retrying request...`);
+                logger.warn('Here is the error message: ');
+                console.dir(err.response?.data);
+                logger.warn('We called this URL: ' + err.response?.config.baseURL + err.response?.config.url);
 
                 const shouldRetry: boolean = retryCodes.includes(err?.response?.status ?? 0);
 
@@ -42,6 +45,11 @@ export class ApiClient {
         });
     }
 
+    /**
+     * Used to initialize/retrive the active ApiClient
+     *
+     * @param session used if initializing
+     */
     public static getInstance(session?: Session): ApiClient {
         if (!ApiClient.instance) {
             ApiClient.instance = new ApiClient(session);
@@ -50,6 +58,16 @@ export class ApiClient {
         return ApiClient.instance;
     }
 
+    public setSession(session: Session): void {
+        if (!ApiClient.instance) {
+            logger.warn("Trying to update ApiCient session when it's not initialized!");
+        }
+
+        this.session = session;
+
+        return;
+    }
+
     /**
      * Call Microsoft Stream API. Base URL is sourced from
      * the session object and prepended automatically.

src/CommandLineParser.ts

@@ -13,12 +13,12 @@ export const argv: any = yargs.options({
     username: {
         alias: 'u',
         type: 'string',
-        describe: 'The username used to log into Microsoft Stream (enabling this will fill in the email field for you)',
+        describe: 'The username used to log into Microsoft Stream (enabling this will fill in the email field for you).',
         demandOption: false
     },
     videoUrls: {
         alias: 'i',
-        describe: 'List of video urls',
+        describe: 'List of urls to videos or Microsoft Stream groups.',
         type: 'array',
         demandOption: false
     },
@@ -30,7 +30,7 @@ export const argv: any = yargs.options({
     },
     outputDirectory: {
         alias: 'o',
-        describe: 'The directory where destreamer will save your downloads',
+        describe: 'The directory where destreamer will save your downloads.',
         type: 'string',
         default: 'videos',
         demandOption: false
@@ -44,42 +44,43 @@ export const argv: any = yargs.options({
     },
     keepLoginCookies: {
         alias: 'k',
-        describe: 'Let Chromium cache identity provider cookies so you can use "Remember me" during login',
+        describe: 'Let Chromium cache identity provider cookies so you can use "Remember me" during login.\n' +
+                  'Must be used every subsequent time you launch Destreamer if you want to log in automatically.',
         type: 'boolean',
         default: false,
         demandOption: false
     },
     noExperiments: {
         alias: 'x',
-        describe: 'Do not attempt to render video thumbnails in the console',
+        describe: 'Do not attempt to render video thumbnails in the console.',
         type: 'boolean',
         default: false,
         demandOption: false
     },
     simulate: {
         alias: 's',
-        describe: 'Disable video download and print metadata information to the console',
+        describe: 'Disable video download and print metadata information to the console.',
         type: 'boolean',
         default: false,
         demandOption: false
     },
     verbose: {
         alias: 'v',
-        describe: 'Print additional information to the console (use this before opening an issue on GitHub)',
+        describe: 'Print additional information to the console (use this before opening an issue on GitHub).',
         type: 'boolean',
         default: false,
         demandOption: false
     },
     closedCaptions: {
         alias: 'cc',
-        describe: 'Check if closed captions are aviable and let the user choose which one to download (will not ask if only one aviable)',
+        describe: 'Check if closed captions are available and let the user choose which one to download (will not ask if only one available).',
         type: 'boolean',
         default: false,
         demandOption: false
     },
     noCleanup: {
         alias: 'nc',
-        describe: 'Do not delete the downloaded video file when an FFmpeg error occurs',
+        describe: 'Do not delete the downloaded video file when an FFmpeg error occurs.',
         type: 'boolean',
         default: false,
         demandOption: false
@@ -97,13 +98,13 @@ export const argv: any = yargs.options({
         demandOption: false
     },
     format: {
-        describe: 'Output container format (mkv, mp4, mov, anything that FFmpeg supports)',
+        describe: 'Output container format (mkv, mp4, mov, anything that FFmpeg supports).',
         type: 'string',
         default: 'mkv',
         demandOption: false
     },
     skip: {
-        describe: 'Skip download if file already exists',
+        describe: 'Skip download if file already exists.',
         type: 'boolean',
         default: false,
         demandOption: false
@@ -173,9 +174,8 @@ function checkInputConflicts(videoUrls: Array<string | number> | undefined,
 
 
 function isOutputTemplateValid(argv: any): boolean {
-    let finalTemplate: string = argv.outputTemplate;
     const elementRegEx = RegExp(/{(.*?)}/g);
-    let match = elementRegEx.exec(finalTemplate);
+    let match = elementRegEx.exec(argv.outputTemplate);
 
     // if no template elements this fails
     if (match) {
@@ -183,30 +183,25 @@ function isOutputTemplateValid(argv: any): boolean {
         while (match) {
             if (!templateElements.includes(match[1])) {
                 logger.error(
-                    `'${match[0]}' is not aviable as a template element \n` +
+                    `'${match[0]}' is not available as a template element \n` +
-                    `Aviable templates elements: '${templateElements.join("', '")}' \n`,
+                    `Available templates elements: '${templateElements.join("', '")}' \n`,
                     { fatal: true }
                 );
 
                 process.exit(1);
             }
-            match = elementRegEx.exec(finalTemplate);
+            match = elementRegEx.exec(argv.outputTemplate);
         }
     }
-    // bad template from user, switching to default
-    else {
-        logger.warn('Empty output template provided, using default one \n');
-        finalTemplate = '{title} - {publishDate} {uniqueId}';
-    }
 
-    argv.outputTemplate = sanitize(finalTemplate.trim());
+    argv.outputTemplate = sanitize(argv.outputTemplate.trim());
 
     return true;
 }
 
 
 export function promptUser(choices: Array<string>): number {
-    let index: number = readlineSync.keyInSelect(choices, 'Which resolution/format do you prefer?');
+    const index: number = readlineSync.keyInSelect(choices, 'Which resolution/format do you prefer?');
 
     if (index === -1) {
         process.exit(ERROR_CODE.CANCELLED_USER_INPUT);

src/Errors.ts

@@ -3,6 +3,7 @@ export const enum ERROR_CODE {
     ELEVATED_SHELL,
     CANCELLED_USER_INPUT,
     MISSING_FFMPEG,
+    OUTDATED_FFMPEG,
     UNK_FFMPEG_ERROR,
     INVALID_VIDEO_GUID,
     NO_SESSION_INFO
@@ -21,6 +22,9 @@ export const errors: {[key: number]: string} = {
     [ERROR_CODE.MISSING_FFMPEG]: 'FFmpeg is missing!\n' +
         'Destreamer requires a fairly recent release of FFmpeg to download videos',
 
+    [ERROR_CODE.MISSING_FFMPEG]: 'The FFmpeg version currently installed is too old!\n' +
+        'Destreamer requires a fairly recent release of FFmpeg to download videos',
+
     [ERROR_CODE.UNK_FFMPEG_ERROR]: 'Unknown FFmpeg error',
 
     [ERROR_CODE.INVALID_VIDEO_GUID]: 'Unable to get video GUID from URL',

src/Thumbnail.ts

@@ -8,7 +8,7 @@ import { AxiosResponse } from 'axios';
 export async function drawThumbnail(posterImage: string, session: Session): Promise<void> {
     const apiClient: ApiClient = ApiClient.getInstance(session);
 
-    let thumbnail: Buffer = await apiClient.callUrl(posterImage, 'get', null, 'arraybuffer')
+    const thumbnail: Buffer = await apiClient.callUrl(posterImage, 'get', null, 'arraybuffer')
         .then((response: AxiosResponse<any> | undefined) => response?.data);
 
     console.log(await terminalImage.buffer(thumbnail, { width: 70 } ));

src/TokenCache.ts

@@ -19,16 +19,16 @@ export class TokenCache {
             return null;
         }
 
-        let session: Session = JSON.parse(fs.readFileSync(this.tokenCacheFile, 'utf8'));
+        const session: Session = JSON.parse(fs.readFileSync(this.tokenCacheFile, 'utf8'));
 
         type Jwt = {
             [key: string]: any
         }
         const decodedJwt: Jwt = jwtDecode(session.AccessToken);
 
-        let now: number = Math.floor(Date.now() / 1000);
+        const now: number = Math.floor(Date.now() / 1000);
-        let exp: number = decodedJwt['exp'];
+        const exp: number = decodedJwt['exp'];
-        let timeLeft: number = exp - now;
+        const timeLeft: number = exp - now;
 
         if (timeLeft < 120) {
             logger.warn('Access token has expired! \n');
@@ -42,12 +42,13 @@ export class TokenCache {
     }
 
     public Write(session: Session): void {
-        let s: string = JSON.stringify(session, null, 4);
+        const s: string = JSON.stringify(session, null, 4);
-        fs.writeFile('.token_cache', s, (err: any) => {
+        fs.writeFile(this.tokenCacheFile, s, (err: any) => {
             if (err) {
                 return logger.error(err);
             }
-            logger.info('Fresh access token dropped into .token_cachen \n'.green);
+
+            logger.info(`Fresh access token dropped into ${this.tokenCacheFile} \n`.green);
         });
     }
 }

src/Types.ts

@@ -16,7 +16,7 @@ export type Video = {
     outPath: string;
     totalChunks: number;    // Abstraction of FFmpeg timemark
     playbackUrl: string;
-    posterImageUrl: string;
+    posterImageUrl: string | null;
     captionsUrl?: string
 }
 

src/Utils.ts

@@ -22,9 +22,21 @@ async function extractGuids(url: string, client: ApiClient): Promise<Array<strin
     else if (groupMatch) {
         const videoNumber: number = await client.callApi(`groups/${groupMatch[1]}`, 'get')
             .then((response: AxiosResponse<any> | undefined) => response?.data.metrics.videos);
+        const result: Array<string> = [];
 
-        let result: Array<string> = await client.callApi(`groups/${groupMatch[1]}/videos?$top=${videoNumber}&$orderby=publishedDate asc`, 'get')
+        // Anything above $top=100 results in 400 Bad Request
-            .then((response: AxiosResponse<any> | undefined) => response?.data.value.map((item: any) => item.id));
+        // Use $skip to skip the first 100 and get another 100 and so on
+        for (let index = 0; index <= Math.floor(videoNumber / 100); index++) {
+            const partial: Array<string> = await client.callApi(
+                `groups/${groupMatch[1]}/videos?$skip=${100 * index}&` +
+                '$top=100&$orderby=publishedDate asc', 'get')
+                .then(
+                    (response: AxiosResponse<any> | undefined) =>
+                        response?.data.value.map((item: any) => item.id)
+                );
+
+            result.push(...partial);
+        }
 
         return result;
     }
@@ -48,7 +60,7 @@ export async function parseCLIinput(urlList: Array<string>, defaultOutDir: strin
     session: Session): Promise<Array<Array<string>>> {
 
     const apiClient: ApiClient = ApiClient.getInstance(session);
-    let guidList: Array<string> = [];
+    const guidList: Array<string> = [];
 
     for (const url of urlList) {
         const guids: Array<string> | null = await extractGuids(url, apiClient);
@@ -85,8 +97,8 @@ export async function parseInputFile(inputFile: string, defaultOutDir: string,
         .split(/\r?\n/);
     const apiClient: ApiClient = ApiClient.getInstance(session);
 
-    let guidList: Array<string> = [];
+    const guidList: Array<string> = [];
-    let outDirList: Array<string> = [];
+    const outDirList: Array<string> = [];
     // if the last line was an url set this
     let foundUrl = false;
 
@@ -101,7 +113,7 @@ export async function parseInputFile(inputFile: string, defaultOutDir: string,
         // parse if line is option
         else if (line.includes('-dir')) {
             if (foundUrl) {
-                let outDir: string | null = parseOption('-dir', line);
+                const outDir: string | null = parseOption('-dir', line);
 
                 if (outDir && checkOutDir(outDir)) {
                     outDirList.push(...Array(guidList.length - outDirList.length)
@@ -181,7 +193,13 @@ export function checkOutDir(directory: string): boolean {
 
 export function checkRequirements(): void {
     try {
+        const copyrightYearRe = new RegExp(/\d{4}-(\d{4})/);
         const ffmpegVer: string = execSync('ffmpeg -version').toString().split('\n')[0];
+
+        if (parseInt(copyrightYearRe.exec(ffmpegVer)?.[1] ?? '0') <= 2019) {
+            process.exit(ERROR_CODE.OUTDATED_FFMPEG);
+        }
+
         logger.verbose(`Using ${ffmpegVer}\n`);
     }
     catch (e) {

src/VideoUtils.ts

@@ -24,14 +24,14 @@ function publishedTimeToString(date: string): string {
     const minutes: string = dateJs.getMinutes().toString();
     const seconds: string = dateJs.getSeconds().toString();
 
-    return `${hours}:${minutes}:${seconds}`;
+    return `${hours}.${minutes}.${seconds}`;
 }
 
 
 function isoDurationToString(time: string): string {
     const duration: Duration = parseDuration(time);
 
-    return `${duration.hours ?? '00'}:${duration.minutes ?? '00'}:${duration.seconds?.toFixed(0) ?? '00'}`;
+    return `${duration.hours ?? '00'}.${duration.minutes ?? '00'}.${duration.seconds?.toFixed(0) ?? '00'}`;
 }
 
 
@@ -46,7 +46,7 @@ function durationToTotalChunks(duration: string): number {
 
 
 export async function getVideoInfo(videoGuids: Array<string>, session: Session, subtitles?: boolean): Promise<Array<Video>> {
-    let metadata: Array<Video> = [];
+    const metadata: Array<Video> = [];
     let title: string;
     let duration: string;
     let publishDate: string;
@@ -65,7 +65,7 @@ export async function getVideoInfo(videoGuids: Array<string>, session: Session,
     /* TODO: change this to a single guid at a time to ease our footprint on the
     MSS servers or we get throttled after 10 sequential reqs */
     for (const guid of videoGuids) {
-        let response: AxiosResponse<any> | undefined =
+        const response: AxiosResponse<any> | undefined =
             await apiClient.callApi('videos/' + guid + '?$expand=creator', 'get');
 
         title = sanitizeWindowsName(response?.data['name']);
@@ -94,7 +94,7 @@ export async function getVideoInfo(videoGuids: Array<string>, session: Session,
         posterImageUrl = response?.data['posterImage']['medium']['url'];
 
         if (subtitles) {
-            let captions: AxiosResponse<any> | undefined = await apiClient.callApi(`videos/${guid}/texttracks`, 'get');
+            const captions: AxiosResponse<any> | undefined = await apiClient.callApi(`videos/${guid}/texttracks`, 'get');
 
             if (!captions?.data.value.length) {
                 captionsUrl = undefined;
@@ -140,7 +140,7 @@ export function createUniquePath(videos: Array<Video>, outDirs: Array<string>, t
         let match = elementRegEx.exec(template);
 
         while (match) {
-            let value = video[match[1] as keyof Video] as string;
+            const value = video[match[1] as keyof Video] as string;
             title = title.replace(match[0], value);
             match = elementRegEx.exec(template);
         }
@@ -152,8 +152,14 @@ export function createUniquePath(videos: Array<Video>, outDirs: Array<string>, t
             finalTitle = `${title}.${++i}`;
         }
 
+        const finalFileName = `${finalTitle}.${format}`;
+        const cleanFileName = sanitizeWindowsName(finalFileName, { replacement: '_' });
+        if (finalFileName !== cleanFileName) {
+            logger.warn(`Not a valid Windows file name: "${finalFileName}".\nReplacing invalid characters with underscores to preserve cross-platform consistency.`);
+        }
+
+        video.outPath = path.join(outDirs[index], finalFileName);
 
-        video.outPath = path.join(outDirs[index], finalTitle + '.' + format);
     });
 
     return videos;

src/destreamer.ts

@@ -13,6 +13,7 @@ import cliProgress from 'cli-progress';
 import fs from 'fs';
 import isElevated from 'is-elevated';
 import puppeteer from 'puppeteer';
+import { ApiClient } from './ApiClient';
 
 
 const { FFmpegCommand, FFmpegInput, FFmpegOutput } = require('@tedconf/fessonia')();
@@ -151,6 +152,7 @@ async function downloadVideo(videoGUIDs: Array<string>, outputDirectories: Array
         if (argv.keepLoginCookies && index !== 0) {
             logger.info('Trying to refresh token...');
             session = await refreshSession('https://web.microsoftstream.com/video/' + videoGUIDs[index]);
+            ApiClient.getInstance().setSession(session);
         }
 
         const pbar: cliProgress.SingleBar = new cliProgress.SingleBar({
@@ -183,8 +185,10 @@ async function downloadVideo(videoGUIDs: Array<string>, outputDirectories: Array
         const headers: string = 'Authorization: Bearer ' + session.AccessToken;
 
         if (!argv.noExperiments) {
+            if (video.posterImageUrl) {
                 await drawThumbnail(video.posterImageUrl, session);
             }
+        }
 
         const ffmpegInpt: any = new FFmpegInput(video.playbackUrl, new Map([
             ['headers', headers]
@@ -268,6 +272,7 @@ async function main(): Promise<void> {
     await init(); // must be first
 
     let session: Session;
+    // eslint-disable-next-line prefer-const
     session = tokenCache.Read() ?? await DoInteractiveLogin('https://web.microsoftstream.com/', argv.username);
 
     logger.verbose('Session and API info \n' +

trigger_codeQL

@@ -0,0 +1 @@
+