1
0
mirror of https://github.com/snobu/destreamer.git synced 2026-03-31 07:49:06 +00:00

2 Commits

Author SHA1 Message Date
snobu
1da56990bc Cleanup README for thumb bug 2021-05-11 11:07:10 +03:00
snobu
7d91f32af2 Fix for null thumbnail URL 2021-05-11 11:06:16 +03:00
3 changed files with 4 additions and 17 deletions

View File

@@ -2,9 +2,6 @@
<img src="https://github.com/snobu/destreamer/workflows/Node%20CI/badge.svg" alt="CI build status" />
</a>
### IMPORTANT NOTE (May 2021)
Please add `-x` (No experiements) to your command line as the MS Stream API is a little flaky returning thumbnails.
**destreamer v3.0** is just around the corner. You can try out a pre-release today by cloning [this branch](https://github.com/snobu/destreamer/tree/aria2c_forRealNow).
![destreamer](assets/logo.png)
@@ -235,18 +232,6 @@ If you get a
````
when running destreamer, then make sure you're running a recent (post year 2019), stable version of **ffmpeg**.
One more -
```
[WARNING] Got HTTP code 400. Retrying request...
[WARNING] Here is the error message:
Buffer(128) [Uint8Array] [
123, 34, 101, 114, 114, 111, 114, 34, 58, 123, 34, 99,
[...]
```
If you get this, add `-x` to your invocation. This should skip thumnbail fetching. The thumbnail API is currently unstable or the thumbnail has not been generated yet. We'll try-catch around that, hopefully soon.
## Contributing
Contributions are welcome. Open an issue first before sending in a pull request. All pull requests require at least one code review before they are merged to master.

View File

@@ -16,7 +16,7 @@ export type Video = {
outPath: string;
totalChunks: number; // Abstraction of FFmpeg timemark
playbackUrl: string;
posterImageUrl: string;
posterImageUrl: string | null;
captionsUrl?: string
}

View File

@@ -185,7 +185,9 @@ async function downloadVideo(videoGUIDs: Array<string>, outputDirectories: Array
const headers: string = 'Authorization: Bearer ' + session.AccessToken;
if (!argv.noExperiments) {
await drawThumbnail(video.posterImageUrl, session);
if (video.posterImageUrl) {
await drawThumbnail(video.posterImageUrl, session);
}
}
const ffmpegInpt: any = new FFmpegInput(video.playbackUrl, new Map([