Fixes and refactoring (#59)

* Input url list: Fix bad Windows behavior * Minor output fix * Fix all download issues - downloads are synchronous again - fix progress bar (fix #39) - nuke fluent and switch to a bug-free ffmpeg module (fessonia) * Move destreamer process events to a new file, we may add more in the future, lets give them their own space * Destreamer: Release packages and builder script ETA when? :P * Clean up * Implement yargs checks and add --videoUrlsFile option * Refactor error handling - Human readable - No magic numbers * Handle mkdir error - remove reduntant message * gitignore: don't add hidden files * Implement --outputDirectories This gives us more flexibility on where to save videos ..especially if your videos have all the same name <.< * Rename utils -> Utils * Fix tests don't import yargs on files other than main * Create scripts directory * Update make_release path * Fix typo * Create CONTRIBUTING.md Co-authored-by: kylon <kylonux@gmail.com>
2026-02-01 21:02:17 +00:00 · 2020-04-14 14:59:14 +02:00
parent 05c36fe718
commit 176fa6e214
15 changed files with 709 additions and 208 deletions
--- a/src/Errors.ts
+++ b/src/Errors.ts
@@ -0,0 +1,63 @@
+interface IError {
+    [key: number]: string
+}
+
+export const enum ERROR_CODE {
+    NO_ERROR,
+    UNHANDLED_ERROR,
+    MISSING_FFMPEG,
+    ELEVATED_SHELL,
+    INVALID_OUTPUT_DIR,
+    INVALID_INPUT_URLS,
+    OUTDIRS_URLS_MISMATCH,
+    INVALID_VIDEO_ID,
+    INVALID_VIDEO_GUID,
+    UNK_FFMPEG_ERROR,
+    NO_SESSION_INFO,
+}
+
+// TODO: create better errors descriptions
+export const Error: IError = {
+    [ERROR_CODE.NO_ERROR]:           'Clean exit with code 0',
+
+    [ERROR_CODE.UNHANDLED_ERROR]:       'Unhandled error!\n' +
+                                        'Timeout or fatal error, please check your downloads directory and try again',
+
+    [ERROR_CODE.ELEVATED_SHELL]:        'Running in an elevated shell',
+
+    [ERROR_CODE.INVALID_OUTPUT_DIR]:    'Unable to create output directory',
+
+    [ERROR_CODE.MISSING_FFMPEG]:        'FFmpeg is missing!\n' +
+                                        'Destreamer requires a fairly recent release of FFmpeg to download videos',
+
+    [ERROR_CODE.UNK_FFMPEG_ERROR]:      'Unknown FFmpeg error',
+
+    [ERROR_CODE.INVALID_INPUT_URLS]:    'No valid URL in the input',
+
+    [ERROR_CODE.OUTDIRS_URLS_MISMATCH]: 'Output directories and URLs mismatch!\n' +
+                                        'You must input the same number of URLs and output directories',
+
+    [ERROR_CODE.INVALID_VIDEO_ID]:      'Unable to get video ID from URL',
+
+    [ERROR_CODE.INVALID_VIDEO_GUID]:    'Unable to get video GUID from URL',
+
+    [ERROR_CODE.NO_SESSION_INFO]:       'Could not evaluate sessionInfo on the page'
+}
+
+export const enum CLI_ERROR {
+    GRACEFULLY_STOP           = ' ', // gracefully stop execution, yargs way
+
+    MISSING_REQUIRED_ARG      = 'You must specify a URLs source.\n' +
+                                'Valid options are --videoUrls or --videoUrlsFile.',
+
+    VIDEOURLS_ARG_CONFLICT    = 'Too many URLs sources specified!\n' +
+                                'Please specify a single URLs source with either --videoUrls or --videoUrlsFile.',
+
+    OUTPUTDIR_ARG_CONFLICT    = 'Too many output arguments specified!\n' +
+                                'Please specify a single output argument with either --outputDirectory or --outputDirectories.',
+
+    FILE_INPUT_VIDEOURLS_ARG  = 'Wrong input for option --videoUrls.\n' +
+                                'To read URLs from file, use --videoUrlsFile option.',
+
+    INPUT_URLS_FILE_NOT_FOUND = 'Input URL list file not found.'
+}