mirror of
https://github.com/nottinghamtec/PyRIGS.git
synced 2026-10-06 20:45:30 +00:00
* Port to Django 5.2 * Pin pluggy to 1.2.0 Any newer and the mystery importlib metadata error appears. Weird! >_> * Update for premailer changed default * Update view logic for is_ajax being changed to a template context processor * Port a few more tests to pytest proper Having two distinct test flavours is giving me a headache * Version 1 dockerfile Makes a VERY big image, I suspect we can optimise this a lot... * Optimise dockerfile a little lot a bit * fix(users): change logout link to POST request * fix(tests): fix some syntax errors in test code still got lots of failed tests :( * fix: replace deprecated Django APIs * ci: update Dockerfile * ci: update Dockerfile * fix(dependencies+tests): update EoL/vulnerable dependencies and improve test stability * Upgrade Python from 3.10 to 3.12 * Update frontend dependencies, replace node-sass with sass * chore(logging): ignore dangling obj reference warning from pypdf * ci: update compose.yml for prod deployment - Add Nginx as a reverse proxy - Add cert-selfsign.sh for generating self-signed certificates - Add certbot-issue.sh for Let's Encrypt certificate issuance and renewal - Add cron-install.sh and cron-uninstall.sh for system cron management - Add .env.example as an environment variable template * style: reformat code * ci: add more sleep trying to pass tests * ci: ignore browser-based tests during ci testing * fix: create home for the new user during Dockerfile building * chore: remove heroku conf file * fix: RIGS not franken anymore * fix: restore is_ajax as a boolean and split out the context processor * test: remove Selenium interaction tests and their CI workarounds * fix: harden production settings (CSRF origins, env casts, ADMINS) and drop dead debug toolbar code * deploy: serve static files from nginx, pin PGDATA, and make cert scripts loud on failure * build: switch .dockerignore to an allowlist * build: drop unused dependencies, soft-pin the rest and target Python 3.14 * build: move image to Python 3.14 / Node 24 and force DEBUG off * ci: add dependabot config for uv, npm, docker and actions * build: narrow Sass deprecation silencing to @import and require Node 24 * build: provide placeholder env for collectstatic now that DEBUG is off in the image * deploy: add plain-HTTP nginx config for local development and use it in compose * deploy: remove self-signed cert script * build: make the image multi-arch with official node and python base images * ci: lint and test on PRs, build the image on PRs and push it to GHCR on master * docs: add local running and sample data instructions * fix: report a form error instead of crashing when big power has no Power MIC * fix: upgrade pypdf and urllib3 to patched releases * fix: apply non-breaking npm audit fixes * fix: strip whitespace in ALLOWED_HOSTS and drop misleading HSTS preload * deploy: add a pyrigs healthcheck and make nginx wait for it * build: pin the uv image version * fix: correct the check-in person picker condition and use BeautifulSoup's string argument * refactor: replace unique_together with UniqueConstraint * build: replace pycodestyle with ruff and fix what it found Removes unused imports and variables, and fixes a few real problems it surfaced: - EventCheckIn.active() referenced an undefined name and raised NameError; it now returns whether the check-in has no end time - RIGS.admin defined EventChecklistAdmin twice; the second is now PowerTestRecordAdmin - RIGS/tests/conftest.py used date/timedelta without importing them - the signal-registering imports in apps.py are kept with noqa pycodestyle config in setup.cfg is dropped. * style: format the codebase with ruff * style: normalise line endings, trailing whitespace and end-of-file newlines * ci: run ruff and file hygiene through prek, and document it --------- Co-authored-by: Hang <me@hangxu.me> Co-authored-by: Joe Banks <joe@jb3.dev>
148 lines
5.8 KiB
Python
148 lines
5.8 KiB
Python
import pytest
|
|
from django.urls import reverse
|
|
from pytest_django.asserts import assertFormError, assertRedirects
|
|
|
|
from PyRIGS.tests.base import assert_oembed, login
|
|
|
|
from assets import models
|
|
|
|
|
|
pytestmark = pytest.mark.django_db
|
|
|
|
|
|
def test_supplier_create(admin_client):
|
|
url = reverse("supplier_create")
|
|
response = admin_client.post(url)
|
|
assertFormError(response.context["form"], "name", "This field is required.")
|
|
|
|
|
|
def test_supplier_edit(admin_client):
|
|
supplier = models.Supplier.objects.create(name="Gadgetron Corporation")
|
|
url = reverse("supplier_update", kwargs={"pk": supplier.pk})
|
|
response = admin_client.post(url, {"name": ""})
|
|
assertFormError(response.context["form"], "name", "This field is required.")
|
|
|
|
|
|
def test_404(admin_client):
|
|
urls = {"asset_detail", "asset_update", "asset_duplicate", "supplier_detail", "supplier_update"}
|
|
for url_name in urls:
|
|
request_url = reverse(url_name, kwargs={"pk": "0000"})
|
|
response = admin_client.get(request_url, follow=True)
|
|
assert response.status_code == 404
|
|
|
|
|
|
def test_embed_login_redirect(client, django_user_model, test_asset):
|
|
request_url = reverse("asset_embed", kwargs={"pk": test_asset.asset_id})
|
|
expected_url = "{0}?next={1}".format(reverse("login_embed"), request_url)
|
|
|
|
# Request the page and check it redirects
|
|
response = client.get(request_url, follow=True)
|
|
assertRedirects(response, expected_url, status_code=302, target_status_code=200)
|
|
|
|
# Now login
|
|
login(client, django_user_model)
|
|
|
|
# And check that it no longer redirects
|
|
response = client.get(request_url, follow=True)
|
|
assert len(response.redirect_chain) == 0
|
|
|
|
|
|
def test_login_cookie_warning(client, django_user_model):
|
|
login_url = reverse("login_embed")
|
|
response = client.post(login_url, follow=True)
|
|
assert "Cookies do not seem to be enabled" in str(response.content)
|
|
|
|
|
|
def test_x_frame_headers(client, django_user_model, test_asset):
|
|
asset_url = reverse("asset_embed", kwargs={"pk": test_asset.asset_id})
|
|
login_url = reverse("login_embed")
|
|
|
|
login(client, django_user_model)
|
|
|
|
response = client.get(asset_url, follow=True)
|
|
with pytest.raises(KeyError):
|
|
response.headers["X-Frame-Options"]
|
|
|
|
response = client.get(login_url, follow=True)
|
|
with pytest.raises(KeyError):
|
|
response.headers["X-Frame-Options"]
|
|
|
|
|
|
def test_oembed(client, test_asset):
|
|
client.logout()
|
|
asset_url = reverse("asset_detail", kwargs={"pk": test_asset.asset_id})
|
|
asset_embed_url = reverse("asset_embed", kwargs={"pk": test_asset.asset_id})
|
|
oembed_url = reverse("asset_oembed", kwargs={"pk": test_asset.asset_id})
|
|
|
|
alt_oembed_url = reverse("asset_oembed", kwargs={"pk": 999})
|
|
alt_asset_embed_url = reverse("asset_embed", kwargs={"pk": 999})
|
|
|
|
assert_oembed(alt_asset_embed_url, alt_oembed_url, client, asset_embed_url, asset_url, oembed_url)
|
|
|
|
|
|
def test_asset_create(admin_client):
|
|
response = admin_client.post(
|
|
reverse("asset_create"),
|
|
{"date_sold": "2000-01-01", "date_acquired": "2020-01-01", "purchase_price": "-30", "replacement_cost": "-30"},
|
|
)
|
|
assertFormError(
|
|
response.context["form"],
|
|
"asset_id",
|
|
["This field is required.", "An Asset ID can only consist of letters and numbers, with a final number"],
|
|
)
|
|
assert_asset_form_errors(response)
|
|
|
|
|
|
def test_cable_create(admin_client):
|
|
response = admin_client.post(reverse("asset_create"), {"asset_id": "X$%A", "is_cable": True})
|
|
assertFormError(
|
|
response.context["form"], "asset_id", "An Asset ID can only consist of letters and numbers, with a final number"
|
|
)
|
|
assertFormError(response.context["form"], "cable_type", "A cable must have a type")
|
|
assertFormError(response.context["form"], "length", "The length of a cable must be more than 0")
|
|
assertFormError(response.context["form"], "csa", "The CSA of a cable must be more than 0")
|
|
|
|
|
|
def test_asset_edit(admin_client, test_asset):
|
|
url = reverse("asset_update", kwargs={"pk": test_asset.asset_id})
|
|
response = admin_client.post(
|
|
url,
|
|
{
|
|
"date_sold": "2000-12-01",
|
|
"date_acquired": "2020-12-01",
|
|
"purchase_price": "-50",
|
|
"replacement_cost": "-50",
|
|
"description": "",
|
|
"status": "",
|
|
"category": "",
|
|
},
|
|
)
|
|
assert_asset_form_errors(response)
|
|
|
|
|
|
def test_cable_edit(admin_client, test_cable):
|
|
url = reverse("asset_update", kwargs={"pk": test_cable.asset_id})
|
|
response = admin_client.post(url, {"is_cable": True, "length": -3, "csa": -3})
|
|
|
|
# TODO Can't figure out how to select the 'none' option...
|
|
# assertFormError(response.context['form'], 'cable_type', 'A cable must have a type')
|
|
assertFormError(response.context["form"], "length", "The length of a cable must be more than 0")
|
|
assertFormError(response.context["form"], "csa", "The CSA of a cable must be more than 0")
|
|
|
|
|
|
def test_asset_duplicate(admin_client, test_cable):
|
|
url = reverse("asset_duplicate", kwargs={"pk": test_cable.asset_id})
|
|
response = admin_client.post(url, {"is_cable": True, "length": 0, "csa": 0})
|
|
|
|
assertFormError(response.context["form"], "length", "The length of a cable must be more than 0")
|
|
assertFormError(response.context["form"], "csa", "The CSA of a cable must be more than 0")
|
|
|
|
|
|
def assert_asset_form_errors(response):
|
|
assertFormError(response.context["form"], "description", "This field is required.")
|
|
assertFormError(response.context["form"], "status", "This field is required.")
|
|
assertFormError(response.context["form"], "category", "This field is required.")
|
|
assertFormError(response.context["form"], "date_sold", "Cannot sell an item before it is acquired")
|
|
assertFormError(response.context["form"], "purchase_price", "A price cannot be negative")
|
|
assertFormError(response.context["form"], "replacement_cost", "A price cannot be negative")
|