Fix for events with no access time

Will close #405

README.md

@@ -1,6 +1,6 @@
 # TEC PA & Lighting - PyRIGS #
 [![Build Status](https://travis-ci.org/nottinghamtec/PyRIGS.svg?branch=develop)](https://travis-ci.org/nottinghamtec/PyRIGS)
-[![Coverage Status](https://coveralls.io/repos/github/nottinghamtec/PyRIGS/badge.svg?branch=develop)](https://coveralls.io/github/nottinghamtec/PyRIGS)
+[![Coverage Status](https://coveralls.io/repos/github/nottinghamtec/PyRIGS/badge.svg)](https://coveralls.io/github/nottinghamtec/PyRIGS)
 
 Welcome to TEC PA & Lightings PyRIGS program. This is a reimplementation of the existing Rig Information Gathering System (RIGS) that was developed using Ruby on Rails.
 

RIGS/models.py

@@ -486,6 +486,10 @@ class Event(models.Model, RevisionMixin):
         if startEndSameDay and hasStartAndEnd and self.start_time > self.end_time:
             raise ValidationError('Unless you\'ve invented time travel, the event can\'t finish before it has started.')
 
+        accessAndStartSameDay = self.access_at is not None and self.start_date == self.access_at.date()
+        if self.access_at.date() > self.start_date or (accessAndStartSameDay and self.access_at.time() > self.start_time):
+            raise ValidationError('Regardless of what some clients might think, access time cannot be after the event has started.')
+
     def save(self, *args, **kwargs):
         """Call :meth:`full_clean` before saving."""
         self.full_clean()

RIGS/rigboard.py

@@ -162,6 +162,7 @@ class EventDuplicate(EventUpdate):
         new = copy.copy(old)  # Make a copy of the object in memory
         new.based_on = old  # Make the new event based on the old event
         new.purchase_order = None  # Remove old PO
+        new.status = new.PROVISIONAL  # Return status to provisional
 
         # Clear checked in by if it's a dry hire
         if new.dry_hire is True:

assets/migrations/0011_asset_nickname.py

@@ -0,0 +1,18 @@
+# Generated by Django 2.0.13 on 2020-03-03 19:40
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('assets', '0010_auto_20200207_1737'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='asset',
+            name='nickname',
+            field=models.CharField(blank=True, max_length=20, null=True, unique=True),
+        ),
+    ]

assets/models.py

@@ -82,6 +82,7 @@ class Asset(models.Model, RevisionMixin):
     category = models.ForeignKey(to=AssetCategory, on_delete=models.CASCADE)
     status = models.ForeignKey(to=AssetStatus, on_delete=models.CASCADE)
     serial_number = models.CharField(max_length=150, blank=True)
+    nickname = models.CharField(max_length=20, blank=True, null=True, unique=True)  # Null = true required because of the unique constraint
     purchased_from = models.ForeignKey(to=Supplier, on_delete=models.CASCADE, blank=True, null=True, related_name="assets")
     date_acquired = models.DateField()
     date_sold = models.DateField(blank=True, null=True)

assets/templates/partials/asset_form.html

@@ -32,6 +32,10 @@
       <label for="{{ form.serial_number.id_for_label }}">Serial Number</label>
       {% render_field form.serial_number|add_class:'form-control' value=object.serial_number %}
     </div>
+    <div class="form-group">
+      <label for="{{ form.nickname.id_for_label }}">Nickname</label>
+      {% render_field form.nickname|add_class:'form-control' value=object.nickname %}
+    </div>
     <!---TODO: Lower default number of lines in comments box-->
     <div class="form-group">
       <label for="{{ form.comments.id_for_label }}">Comments</label>
@@ -53,6 +57,9 @@
     <dt>Serial Number</dt>
     <dd>{{ object.serial_number|default:'-' }}</dd>
 
+    <dt>Nickname</dt>
+    <dd>{{ object.nickname|default:'-' }}</dd>
+
     <dt>Comments</dt>
     <dd style="overflow-wrap: break-word;">{{ object.comments|default:'-'|linebreaksbr }}</dd>
     {% endif %}