Commit Graph

22 Commits

Author SHA1 Message Date
da0c9ba87b Start tests for audit 2020-02-23 23:31:12 +00:00
da48a75073 FIX: Hide asset detail buttons for basic users 2020-02-18 16:00:33 +00:00
b9434dc576 FIX: Stop quickbuttons being tab-selected
If someone's tabbing through, they won't be needing the buttons...
2020-02-17 21:27:26 +00:00
75660644eb FEAT: More handy buttons 2020-02-17 21:25:25 +00:00
68891dccd2 FEAT: Add buttons for some common defaults on audit form
TODO: Partialise those fragments and add them to the edit/create forms too.
2020-02-17 13:10:51 +00:00
759faf30f1 FIX: Gracefully handle 404s in audit search 2020-02-17 13:00:35 +00:00
20d9a71a9e FIX: Remove assets from to-be-audited table when audited
Previously required a page reload
2020-02-16 15:49:53 +00:00
54ec38f7e1 Various UX Improvements
Also rearranged asset detail/edit to be more space efficient
2020-02-16 15:37:09 +00:00
ed5339925e FIX: Revert partialising of asset search 2020-02-16 02:41:36 +00:00
0b2fc6d57c Added cable functionality to audit form
Also improved styling
2020-02-16 02:34:33 +00:00
e656b90a22 Improve audit search bar
Optimise for APM!
2020-02-15 12:54:12 +00:00
7c42ad853c WIP: Javascript shenanigans for asset audit search
It's not clean but it works..
2020-02-14 17:20:50 +00:00
e7fcaa36bb WIP: Audit modal works
Need to get the ID search working.
2020-02-14 11:47:05 +00:00
e9a9250027 WIP: Basic work on audit 2020-02-10 00:09:46 +00:00
ae151ed45e Add assets test suite (#400)
* Started POM and assets test

* FEAT: Adapt unit tests from RIGS to assets

* CHORE: pep8...

* Added Asset Create and Edit forms

* Add non-cable asset creation test

* CHORE: Frickin pep8...

* Add cable asset creation test

* Basic asset create validation testing

* Asset edit tests are here

A bit dodgy in places but par for the course for me :P

* Add access level tests

* Delete unused code

Much less effort way to increase coverage stats :D

* Add delete sample data test for completeness

Chasing that sweet 100% coverage...

* Add supplier list page + tests

Also fix the supplier page not being ordered alphabetically

* Helps if I add the migration...

* Add supplier create/edit tests

* Asset duplicate tests

Also fixed some random bugs

* Asset search tests

* 404 tests and test that everything requires authentication

* Test visibility of form errors

And fix supplier form not displaying errors correctly!

* Fix broken search test


Co-authored-by: Matthew Smith <mattysmith22@googlemail.com>
2020-02-08 13:52:07 +00:00
6ba87b0a5a CHANGE: Restructure the asset embed a bit
Should fix the forum mangling
2020-01-21 01:45:59 +00:00
630011aff7 FEAT: Add oembed for assets (#393)
* FEAT: Add oembed for assets

Don't see the worth in doing supplier currently...we don't OEmbed Org/Venue etc after all...

* FIX Copy paste error ;D

* Fix embeds not actually working for unauthenticated users

This is why I should have written tests...
2020-01-17 15:28:29 +00:00
4ad12ab40a FIX: Prevent basic users seeing individual asset version history
I prevented them from seeing the change stream, didn't prevent them seeing individual histories. This has to be done as otherwise it leaks financial information. If I can be arsed I'll come back to this and allow basic users to see a filtered version.
2020-01-11 21:13:50 +00:00
82a30ca77d Miscellaneous changes to the Asset DB (#390)
* FIX #388: Prevent assets losing supplier data on edit

* FEAT: Add associated assets to supplier detail view

* FIX: Tweak supplier list to make detail view accessible

* Potential fix for #380

No idea if it works because I can't reproduce locally. S/O Reckons it should... :P

* FEAT #386: Asset search searches serial number.

Pending addition of advanced search.

* FIX: Order asset categories/statuses alphabetically

Instead of by pk because that's silly.

* FEAT: Statuses can have a CSS class defined in the admin panel

This replaces the hardcoding of colours in the asset list.

* FIX: Squash migrations

* Fixed supplier not working on all the create asset template

* Refactored away "assets" property on "Supplier" by using "related_name" instead

Co-authored-by: Matthew Smith <mattysmith22@googlemail.com>
2020-01-03 21:46:39 +00:00
01a87e0e0b FEAT: Add revision history to assets and suppliers (#387)
* FEAT: Initial work on revision history for assets

The revision history for individual items mostly works, though it shows database ID where it should show asset ID. Recent changes feed isn't yet done.

* FEAT: Initial implementation of asset activity stream

* CHORE: Fix pep8

* FIX: Asset history table 'branding'

* FIX: Individual asset version history is now correctly filtered

* FEAT: Make revision history for suppliers accessible

* CHORE: *sings* And a pep8 in a broken tree...

* Refactored out duplicated code from `AssetVersionHistory

* CHORE: pep8

And another random bit of wierd whitespace I found

Co-authored-by: Matthew Smith <mattysmith22@googlemail.com>

Closes #358
2019-12-31 12:25:42 +00:00
0d8fd99d92 FIX: Permission errors
This fixes keyholders being unable to see financials information or create assets. (Well, the latter needs anyone to be able to create assets before it is fully fixed)
2019-12-05 13:00:47 +00:00
4f036af85a Create the Asset Database (#363) 2019-12-04 23:14:27 +00:00