Fix PEP8 fails

This commit is contained in:
Tom Price
2015-06-02 00:15:26 +01:00
parent 7df44755f4
commit fe06db5e37

View File

@@ -6,262 +6,297 @@ from RIGS import models
import re import re
import os import os
class UserRegistrationTest(LiveServerTestCase): class UserRegistrationTest(LiveServerTestCase):
def setUp(self):
self.browser = webdriver.Firefox()
os.environ['RECAPTCHA_TESTING'] = 'True'
def tearDown(self): def setUp(self):
self.browser.quit() self.browser = webdriver.Firefox()
os.environ['RECAPTCHA_TESTING'] = 'False' os.environ['RECAPTCHA_TESTING'] = 'True'
def test_registration(self): def tearDown(self):
# Navigate to the registration page self.browser.quit()
self.browser.get(self.live_server_url + '/user/register/') os.environ['RECAPTCHA_TESTING'] = 'False'
#self.browser.implicitly_wait(3)
title_text = self.browser.find_element_by_tag_name('h3').text
self.assertIn("User Registration", title_text)
# Check the form invites correctly
username = self.browser.find_element_by_id('id_username')
self.assertEqual(username.get_attribute('placeholder'), 'Username')
email = self.browser.find_element_by_id('id_email')
self.assertEqual(email.get_attribute('placeholder'), 'E-mail')
self.assertEqual(email.get_attribute('type'), 'email') # If this is correct we don't need to test it later
password1 = self.browser.find_element_by_id('id_password1')
self.assertEqual(password1.get_attribute('placeholder'), 'Password')
self.assertEqual(password1.get_attribute('type'), 'password')
password2 = self.browser.find_element_by_id('id_password2')
self.assertEqual(password2.get_attribute('placeholder'), 'Password confirmation')
self.assertEqual(password2.get_attribute('type'), 'password')
first_name = self.browser.find_element_by_id('id_first_name')
self.assertEqual(first_name.get_attribute('placeholder'), 'First name')
last_name = self.browser.find_element_by_id('id_last_name')
self.assertEqual(last_name.get_attribute('placeholder'), 'Last name')
initials = self.browser.find_element_by_id('id_initials')
self.assertEqual(initials.get_attribute('placeholder'), 'Initials')
phone = self.browser.find_element_by_id('id_phone')
self.assertEqual(phone.get_attribute('placeholder'), 'Phone')
# Fill the form out incorrectly
username.send_keys('TestUsername')
email.send_keys('test@example.com')
password1.send_keys('correcthorsebatterystaple')
password2.send_keys('correcthorsebatterystapleerror') # deliberate mistake
first_name.send_keys('John')
last_name.send_keys('Smith')
initials.send_keys('JS')
phone.send_keys('0123456789')
self.browser.execute_script("return jQuery('#g-recaptcha-response').val('PASSED')")
# Submit incorrect form def test_registration(self):
submit = self.browser.find_element_by_xpath("//input[@type='submit']") # Navigate to the registration page
submit.click() self.browser.get(self.live_server_url + '/user/register/')
# Restablish error fields # self.browser.implicitly_wait(3)
password1 = self.browser.find_element_by_id('id_password1') title_text = self.browser.find_element_by_tag_name('h3').text
password2 = self.browser.find_element_by_id('id_password2') self.assertIn("User Registration", title_text)
# Read what the error is # Check the form invites correctly
alert = self.browser.find_element_by_css_selector('div.alert-danger').text username = self.browser.find_element_by_id('id_username')
self.assertIn("password fields didn't match", alert) self.assertEqual(username.get_attribute('placeholder'), 'Username')
email = self.browser.find_element_by_id('id_email')
self.assertEqual(email.get_attribute('placeholder'), 'E-mail')
# If this is correct we don't need to test it later
self.assertEqual(email.get_attribute('type'), 'email')
password1 = self.browser.find_element_by_id('id_password1')
self.assertEqual(password1.get_attribute('placeholder'), 'Password')
self.assertEqual(password1.get_attribute('type'), 'password')
password2 = self.browser.find_element_by_id('id_password2')
self.assertEqual(
password2.get_attribute('placeholder'), 'Password confirmation')
self.assertEqual(password2.get_attribute('type'), 'password')
first_name = self.browser.find_element_by_id('id_first_name')
self.assertEqual(first_name.get_attribute('placeholder'), 'First name')
last_name = self.browser.find_element_by_id('id_last_name')
self.assertEqual(last_name.get_attribute('placeholder'), 'Last name')
initials = self.browser.find_element_by_id('id_initials')
self.assertEqual(initials.get_attribute('placeholder'), 'Initials')
phone = self.browser.find_element_by_id('id_phone')
self.assertEqual(phone.get_attribute('placeholder'), 'Phone')
# Passwords should be empty # Fill the form out incorrectly
self.assertEqual(password1.get_attribute('value'), '') username.send_keys('TestUsername')
self.assertEqual(password2.get_attribute('value'), '') email.send_keys('test@example.com')
password1.send_keys('correcthorsebatterystaple')
# deliberate mistake
password2.send_keys('correcthorsebatterystapleerror')
first_name.send_keys('John')
last_name.send_keys('Smith')
initials.send_keys('JS')
phone.send_keys('0123456789')
self.browser.execute_script(
"return jQuery('#g-recaptcha-response').val('PASSED')")
# Correct error # Submit incorrect form
password1.send_keys('correcthorsebatterystaple') submit = self.browser.find_element_by_xpath("//input[@type='submit']")
password2.send_keys('correcthorsebatterystaple') submit.click()
self.browser.execute_script("return jQuery('#g-recaptcha-response').val('PASSED')") # Restablish error fields
password1 = self.browser.find_element_by_id('id_password1')
password2 = self.browser.find_element_by_id('id_password2')
# Submit again # Read what the error is
password2.send_keys(Keys.ENTER) alert = self.browser.find_element_by_css_selector(
'div.alert-danger').text
self.assertIn("password fields didn't match", alert)
# Check we have a success message # Passwords should be empty
alert = self.browser.find_element_by_css_selector('div.alert-success').text self.assertEqual(password1.get_attribute('value'), '')
self.assertIn('register', alert) self.assertEqual(password2.get_attribute('value'), '')
self.assertIn('email', alert)
# Check Email # Correct error
self.assertEqual(len(mail.outbox), 1) password1.send_keys('correcthorsebatterystaple')
email = mail.outbox[0] password2.send_keys('correcthorsebatterystaple')
self.assertIn('activation required', email.subject) self.browser.execute_script(
urls = re.findall('http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+', email.message) "return jQuery('#g-recaptcha-response').val('PASSED')")
self.assertEqual(len(urls), 2)
mail.outbox = [] # empty this for later # Submit again
password2.send_keys(Keys.ENTER)
# Follow link # Check we have a success message
self.browser.get(urls[1]) # go to the second link alert = self.browser.find_element_by_css_selector(
'div.alert-success').text
self.assertIn('register', alert)
self.assertIn('email', alert)
# Complete registration # Check Email
title_text = self.browser.find_element_by_tag_name('h2') self.assertEqual(len(mail.outbox), 1)
self.assertIn('Complete', title_text) email = mail.outbox[0]
self.assertIn('activation required', email.subject)
urls = re.findall(
'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+', email.message)
self.assertEqual(len(urls), 2)
# Test login mail.outbox = [] # empty this for later
self.browser.get(self.live_server_url + '/user/login')
username = self.browser.find_element_by_id('id_username')
self.assertEqual(username.get_attribute('placeholder'), 'Username')
password = self.browser.find_element_by_id('id_password')
self.assertEqual(password.get_attribute('placeholder'), 'Password')
self.assertEqual(password.get_attribute('type'), 'password')
username.send_keys('TestUsername') # Follow link
password.send_keys('correcthorsebatterystaple') self.browser.get(urls[1]) # go to the second link
password.send_keys(Keys.ENTER)
self.browser.execute_script("return jQuery('#g-recaptcha-response').val('PASSED')")
# Check we are logged in # Complete registration
udd = self.browser.find_element_by_id('userdropdown') title_text = self.browser.find_element_by_tag_name('h2')
self.assertIn('Hi John', udd) self.assertIn('Complete', title_text)
# Test login
self.browser.get(self.live_server_url + '/user/login')
username = self.browser.find_element_by_id('id_username')
self.assertEqual(username.get_attribute('placeholder'), 'Username')
password = self.browser.find_element_by_id('id_password')
self.assertEqual(password.get_attribute('placeholder'), 'Password')
self.assertEqual(password.get_attribute('type'), 'password')
username.send_keys('TestUsername')
password.send_keys('correcthorsebatterystaple')
password.send_keys(Keys.ENTER)
self.browser.execute_script(
"return jQuery('#g-recaptcha-response').val('PASSED')")
# Check we are logged in
udd = self.browser.find_element_by_id('userdropdown')
self.assertIn('Hi John', udd)
# All is well
# All is well
class EventTest(LiveServerTestCase): class EventTest(LiveServerTestCase):
def setUp(self):
self.profile = models.Profile(username="EventTest", first_name="Event", last_name="Test", initials="ETU", is_superuser=True)
self.profile.set_password("EventTestPassword")
self.profile.save()
self.browser = webdriver.Firefox() def setUp(self):
os.environ['RECAPTCHA_TESTING'] = 'True' self.profile = models.Profile(
username="EventTest", first_name="Event", last_name="Test", initials="ETU", is_superuser=True)
self.profile.set_password("EventTestPassword")
self.profile.save()
def tearDown(self): self.browser = webdriver.Firefox()
self.browser.quit() os.environ['RECAPTCHA_TESTING'] = 'True'
os.environ['RECAPTCHA_TESTING'] = 'False'
def authenticate(self, n=None): def tearDown(self):
self.assertIn(self.live_server_url + '/user/login/', self.browser.current_url) self.browser.quit()
if n: os.environ['RECAPTCHA_TESTING'] = 'False'
self.assertIn('?next=%s'%n, self.browser.current_url)
username = self.browser.find_element_by_id('id_username')
password = self.browser.find_element_by_id('id_password')
submit = self.browser.find_element_by_css_selector('input[type=submit]')
username.send_keys("EventTest") def authenticate(self, n=None):
password.send_keys("EventTestPassword") self.assertIn(
self.browser.execute_script("return jQuery('#g-recaptcha-response').val('PASSED')") self.live_server_url + '/user/login/', self.browser.current_url)
submit.click() if n:
self.assertIn('?next=%s' % n, self.browser.current_url)
username = self.browser.find_element_by_id('id_username')
password = self.browser.find_element_by_id('id_password')
submit = self.browser.find_element_by_css_selector(
'input[type=submit]')
self.assertEqual(self.live_server_url + n, self.browser.current_url) username.send_keys("EventTest")
password.send_keys("EventTestPassword")
self.browser.execute_script(
"return jQuery('#g-recaptcha-response').val('PASSED')")
submit.click()
def testRigboardButtons(self): self.assertEqual(self.live_server_url + n, self.browser.current_url)
# Requests address
self.browser.get(self.live_server_url + '/rigboard/')
# Gets redirected to login
self.authenticate('/rigboard/')
# Completes and comes back to rigboard def testRigboardButtons(self):
# Clicks add new # Requests address
self.browser.find_element_by_partial_link_text("New").click() self.browser.get(self.live_server_url + '/rigboard/')
self.assertEqual(self.live_server_url + '/event/create/', self.browser.current_url) # Gets redirected to login
self.browser.get(self.live_server_url + '/rigboard/') self.authenticate('/rigboard/')
def testRigCreate(self): # Completes and comes back to rigboard
# Requests address # Clicks add new
self.browser.get(self.live_server_url + '/event/create/') self.browser.find_element_by_partial_link_text("New").click()
# Gets redirected to login and back self.assertEqual(
self.authenticate('/event/create/') self.live_server_url + '/event/create/', self.browser.current_url)
self.browser.get(self.live_server_url + '/rigboard/')
# Check has slided up correctly - third save button hidden def testRigCreate(self):
save = self.browser.find_element_by_xpath('(//button[@type="submit"])[3]') # Requests address
self.assertFalse(save.is_displayed()) self.browser.get(self.live_server_url + '/event/create/')
# Gets redirected to login and back
self.authenticate('/event/create/')
# Click Rig button # Check has slided up correctly - third save button hidden
self.browser.find_element_by_xpath('//button[.="Rig"]').click() save = self.browser.find_element_by_xpath(
'(//button[@type="submit"])[3]')
self.assertFalse(save.is_displayed())
# Slider expands and save button visible # Click Rig button
self.assertTrue(save.is_displayed()) self.browser.find_element_by_xpath('//button[.="Rig"]').click()
form = self.browser.find_element_by_tag_name('form')
# Create new person # Slider expands and save button visible
add_person_button = self.browser.find_element_by_xpath('//a[@data-target="#id_person" and contains(@href, "add")]') self.assertTrue(save.is_displayed())
add_person_button.click() form = self.browser.find_element_by_tag_name('form')
# See modal has opened # Create new person
modal = self.browser.find_element_by_id('modal') add_person_button = self.browser.find_element_by_xpath(
self.browser.implicitly_wait(3) '//a[@data-target="#id_person" and contains(@href, "add")]')
self.assertTrue(modal.is_displayed()) add_person_button.click()
self.assertIn("Add Person", modal.find_element_by_tag_name('h3').text)
# Fill person form out and submit # See modal has opened
modal.find_element_by_xpath('//div[@id="modal"]//input[@id="id_name"]').send_keys("Test Person 1") modal = self.browser.find_element_by_id('modal')
modal.find_element_by_xpath('//div[@id="modal"]//input[@type="submit"]').click() self.browser.implicitly_wait(3)
self.browser.implicitly_wait(3) self.assertTrue(modal.is_displayed())
self.assertFalse(modal.is_displayed()) self.assertIn("Add Person", modal.find_element_by_tag_name('h3').text)
# See new person selected # Fill person form out and submit
person1 = models.Person.objects.get(name="Test Person 1") modal.find_element_by_xpath(
self.assertEqual(person1.name, form.find_element_by_xpath('//button[@data-id="id_person"]/span').text) '//div[@id="modal"]//input[@id="id_name"]').send_keys("Test Person 1")
# and backend modal.find_element_by_xpath(
option = form.find_element_by_xpath('//select[@id="id_person"]//option[@selected="selected"]') '//div[@id="modal"]//input[@type="submit"]').click()
self.assertEqual(person1.pk, int(option.get_attribute("value"))) self.browser.implicitly_wait(3)
self.assertFalse(modal.is_displayed())
# Change mind and add another # See new person selected
add_person_button.click() person1 = models.Person.objects.get(name="Test Person 1")
self.assertEqual(person1.name, form.find_element_by_xpath(
'//button[@data-id="id_person"]/span').text)
# and backend
option = form.find_element_by_xpath(
'//select[@id="id_person"]//option[@selected="selected"]')
self.assertEqual(person1.pk, int(option.get_attribute("value")))
self.browser.implicitly_wait(3) # Change mind and add another
self.assertTrue(modal.is_displayed()) add_person_button.click()
self.assertIn("Add Person", modal.find_element_by_tag_name('h3').text)
modal.find_element_by_xpath('//div[@id="modal"]//input[@id="id_name"]').send_keys("Test Person 2") self.browser.implicitly_wait(3)
modal.find_element_by_xpath('//div[@id="modal"]//input[@type="submit"]').click() self.assertTrue(modal.is_displayed())
self.browser.implicitly_wait(3) self.assertIn("Add Person", modal.find_element_by_tag_name('h3').text)
self.assertFalse(modal.is_displayed())
person2 = models.Person.objects.get(name="Test Person 2") modal.find_element_by_xpath(
self.assertEqual(person2.name, form.find_element_by_xpath('//button[@data-id="id_person"]/span').text) '//div[@id="modal"]//input[@id="id_name"]').send_keys("Test Person 2")
# Have to do this explcitly to force the wait for it to update modal.find_element_by_xpath(
option = form.find_element_by_xpath('//select[@id="id_person"]//option[@selected="selected"]') '//div[@id="modal"]//input[@type="submit"]').click()
self.assertEqual(person2.pk, int(option.get_attribute("value"))) self.browser.implicitly_wait(3)
self.assertFalse(modal.is_displayed())
# Was right the first time, change it back person2 = models.Person.objects.get(name="Test Person 2")
person_select = form.find_element_by_xpath('//button[@data-id="id_person"]') self.assertEqual(person2.name, form.find_element_by_xpath(
person_select.send_keys(person1.name) '//button[@data-id="id_person"]/span').text)
person_dropped = form.find_element_by_xpath('//ul[contains(@class, "inner selectpicker")]//span[contains(text(), "%s")]'%person1.name) # Have to do this explcitly to force the wait for it to update
person_dropped.click() option = form.find_element_by_xpath(
'//select[@id="id_person"]//option[@selected="selected"]')
self.assertEqual(person2.pk, int(option.get_attribute("value")))
self.assertEqual(person1.name, form.find_element_by_xpath('//button[@data-id="id_person"]/span').text) # Was right the first time, change it back
option = form.find_element_by_xpath('//select[@id="id_person"]//option[@selected="selected"]') person_select = form.find_element_by_xpath(
self.assertEqual(person1.pk, int(option.get_attribute("value"))) '//button[@data-id="id_person"]')
person_select.send_keys(person1.name)
person_dropped = form.find_element_by_xpath(
'//ul[contains(@class, "inner selectpicker")]//span[contains(text(), "%s")]' % person1.name)
person_dropped.click()
# Edit Person 1 to have a better name self.assertEqual(person1.name, form.find_element_by_xpath(
form.find_element_by_xpath('//a[@data-target="#id_person" and contains(@href, "%s/edit/")]'%person1.pk).click() '//button[@data-id="id_person"]/span').text)
self.browser.implicitly_wait(3) option = form.find_element_by_xpath(
self.assertTrue(modal.is_displayed()) '//select[@id="id_person"]//option[@selected="selected"]')
self.assertIn("Edit Person", modal.find_element_by_tag_name('h3').text) self.assertEqual(person1.pk, int(option.get_attribute("value")))
name = modal.find_element_by_xpath('//div[@id="modal"]//input[@id="id_name"]')
self.assertEqual(person1.name, name.get_attribute('value'))
name.clear()
name.send_keys('Rig ' + person1.name)
name.send_keys(Keys.ENTER)
self.browser.implicitly_wait(3)
self.assertFalse(modal.is_displayed())
person1 = models.Person.objects.get(pk=person1.pk)
self.assertEqual(person1.name, form.find_element_by_xpath('//button[@data-id="id_person"]/span').text)
# Create organisation # Edit Person 1 to have a better name
form.find_element_by_xpath(
'//a[@data-target="#id_person" and contains(@href, "%s/edit/")]' % person1.pk).click()
self.browser.implicitly_wait(3)
self.assertTrue(modal.is_displayed())
self.assertIn("Edit Person", modal.find_element_by_tag_name('h3').text)
name = modal.find_element_by_xpath(
'//div[@id="modal"]//input[@id="id_name"]')
self.assertEqual(person1.name, name.get_attribute('value'))
name.clear()
name.send_keys('Rig ' + person1.name)
name.send_keys(Keys.ENTER)
self.browser.implicitly_wait(3)
self.assertFalse(modal.is_displayed())
person1 = models.Person.objects.get(pk=person1.pk)
self.assertEqual(person1.name, form.find_element_by_xpath(
'//button[@data-id="id_person"]/span').text)
# See it is selected # Create organisation
# Create veneue # See it is selected
# See it selected # Create veneue
# Set start date/time # See it selected
# Set end date/time # Set start date/time
# Add item # Set end date/time
# See new item appear # Add item
# Attempt to save - missing title # See new item appear
# See error and all data preserved # Attempt to save - missing title
# Set title # See error and all data preserved
# Save again # Set title
# See redirected to success page # Save again
# See redirected to success page