From d64d0f54d42e48f16306f7640835ddb90407a4d2 Mon Sep 17 00:00:00 2001 From: Arona Jones Date: Tue, 26 Jan 2021 19:37:12 +0000 Subject: [PATCH] Should fix asset test on CI --- assets/tests/pages.py | 1 - assets/tests/test_assets.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/assets/tests/pages.py b/assets/tests/pages.py index f7ff25b4..d6a85b3e 100644 --- a/assets/tests/pages.py +++ b/assets/tests/pages.py @@ -244,7 +244,6 @@ class AssetAuditList(AssetList): def close(self): self.page.find_element(*self._close_selector).click() - self.wait.until(expected_conditions.invisibility_of_element_located((By.ID, 'modal'))) def remove_all_required(self): self.driver.execute_script("Array.from(document.getElementsByTagName(\"input\")).forEach(function (el, ind, arr) { el.removeAttribute(\"required\")});") diff --git a/assets/tests/test_assets.py b/assets/tests/test_assets.py index d756029e..ec4f2f14 100644 --- a/assets/tests/test_assets.py +++ b/assets/tests/test_assets.py @@ -326,8 +326,8 @@ class TestAssetAudit(AutoLoginTest): self.wait.until(EC.visibility_of_element_located((By.ID, 'modal'))) self.assertEqual(self.page.modal.asset_id, asset_row.id) - # First close button is for the not found error self.page.modal.close() + self.wait.until(EC.invisibility_of_element_located((By.ID, 'modal'))) self.assertFalse(self.driver.find_element_by_id('modal').is_displayed()) # Make sure audit log was NOT filled out audited = models.Asset.objects.get(asset_id=asset_row.id)