Add assets test suite (#400)

* Started POM and assets test

* FEAT: Adapt unit tests from RIGS to assets

* CHORE: pep8...

* Added Asset Create and Edit forms

* Add non-cable asset creation test

* CHORE: Frickin pep8...

* Add cable asset creation test

* Basic asset create validation testing

* Asset edit tests are here

A bit dodgy in places but par for the course for me :P

* Add access level tests

* Delete unused code

Much less effort way to increase coverage stats :D

* Add delete sample data test for completeness

Chasing that sweet 100% coverage...

* Add supplier list page + tests

Also fix the supplier page not being ordered alphabetically

* Helps if I add the migration...

* Add supplier create/edit tests

* Asset duplicate tests

Also fixed some random bugs

* Asset search tests

* 404 tests and test that everything requires authentication

* Test visibility of form errors

And fix supplier form not displaying errors correctly!

* Fix broken search test


Co-authored-by: Matthew Smith <mattysmith22@googlemail.com>

assets/templates/asset_create.html

@@ -1,6 +1,5 @@
 {% extends 'base_assets.html' %}
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 {% block title %}Asset {{ object.asset_id }}{% endblock %}
 
 {% block content %}

assets/templates/asset_list.html

@@ -17,16 +17,16 @@
   </div>
   <br>
   <div style="margin-top: 1em;" class="pull-right">
-      <div class="form-group">
+      <div id="category-group" class="form-group">
         <label for="category" class="sr-only">Category</label>
         {% render_field form.category|attr:'multiple'|add_class:'form-control selectpicker' data-none-selected-text="Categories" data-header="Categories" data-actions-box="true" %}
       </div>
-      <div class="form-group">
+      <div id="status-group" class="form-group">
         <label for="status" class="sr-only">Status</label>
         {% render_field form.status|attr:'multiple'|add_class:'form-control selectpicker' data-none-selected-text="Statuses" data-header="Statuses" data-actions-box="true" %}
       </div>
       <!---TODO: Auto filter whenever an option is selected, instead of using a button -->
-      <button type="submit" class="btn btn-default">Filter</button>
+      <button id="filter-submit" type="submit" class="btn btn-default">Filter</button>
     </div>
 </form>
 

assets/templates/asset_update.html

@@ -1,6 +1,5 @@
 {% extends 'base_assets.html' %}
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 {% block title %}Asset {{ object.asset_id }}{% endblock %}
 
 {% block content %}
@@ -40,7 +39,6 @@
   <div class="row">
     <div class="col-md-12">
       {% include 'partials/asset_buttons.html' %}
-    </div>
   </div>
 </form>
 

assets/templates/partials/asset_buttons.html

@@ -4,7 +4,7 @@
 <a class="btn btn-default" href="{% url 'asset_duplicate' object.pk %}"><i class="glyphicon glyphicon-duplicate"></i> Duplicate</a>
 {% elif duplicate %}
 <!--duplicate-->
-<button type="submit" class="btn btn-default"><i class="glyphicon glyphicon-ok-sign"></i> Create Duplicate</button>
+<button type="submit" class="btn btn-success"><i class="glyphicon glyphicon-ok-sign"></i> Create Duplicate</button>
 {% elif create %}
 <!--create-->
 <button type="submit" class="btn btn-success"><i class="glyphicon glyphicon-floppy-disk"></i> Save</button>

assets/templates/partials/asset_form.html

@@ -1,5 +1,4 @@
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 <div class="panel panel-default">
   <div class="panel-heading">
     Asset Details

assets/templates/partials/asset_list_table_body.html

@@ -1,10 +1,11 @@
 {% for item in object_list %}
     {#                <li><a href="{% url 'asset_detail' item.pk %}">{{ item.asset_id }} - {{ item.description }}</a></li>#}
-    <!---TODO: When the ability to filter the list is added, remove the colours from the filter - specifically, stop greying out sold/binned stuff if it is being searched for-->    <tr class={{ item.status.display_class|default:"" }}>
-        <td style="vertical-align: middle;"><a href="{% url 'asset_detail' item.asset_id %}">{{ item.asset_id }}</a></td>
-        <td style="vertical-align: middle; text-overflow: ellipsis; white-space: nowrap; overflow: hidden; max-width: 25vw">{{ item.description }}</td>
-        <td style="vertical-align: middle;">{{ item.category }}</td>
-        <td style="vertical-align: middle;">{{ item.status }}</td>
+    <!---TODO: When the ability to filter the list is added, remove the colours from the filter - specifically, stop greying out sold/binned stuff if it is being searched for-->
+    <tr class="{{ item.status.display_class|default:'' }} assetRow">
+        <td style="vertical-align: middle;"><a class="assetID" href="{% url 'asset_detail' item.asset_id %}">{{ item.asset_id }}</a></td>
+        <td class="assetDesc" style="vertical-align: middle; text-overflow: ellipsis; white-space: nowrap; overflow: hidden; max-width: 25vw">{{ item.description }}</td>
+        <td class="assetCategory" style="vertical-align: middle;">{{ item.category }}</td>
+        <td class="assetStatus" style="vertical-align: middle;">{{ item.status }}</td>
         <td class="hidden-xs">
             <div class="btn-group" role="group">
                 <a type="button" class="btn btn-default btn-sm" href="{% url 'asset_detail' item.asset_id %}"><i class="glyphicon glyphicon-eye-open"></i> View</a>

assets/templates/partials/cable_form.html

@@ -1,5 +1,4 @@
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 <div class="panel panel-default">
   <div class="panel-heading">
     Cable Details

assets/templates/partials/parent_form.html

@@ -1,12 +1,11 @@
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 <div class="panel panel-default">
   <div class="panel-heading">
     Collection Details
   </div>
   <div class="panel-body">
     {% if create or edit or duplicate %}
-    <div class="form-group">
+    <div class="form-group" id="parent-group">
       <label for="selectpicker">Set Parent</label>
       {% include 'partials/asset_picker.html' %}
     </div>

assets/templates/partials/purchasedetails_form.html

@@ -1,5 +1,4 @@
 {% load widget_tweaks %}
-{% load asset_templatetags %}
 {% load static %}
 
 
@@ -23,7 +22,7 @@
   </div>
   <div class="panel-body">
     {% if create or edit or duplicate %}
-    <div class="form-group">
+    <div class="form-group" id="purchased-from-group">
       <label for="{{ form.purchased_from.id_for_label }}">Supplier</label>
       <select id="{{ form.purchased_from.id_for_label }}" name="{{ form.purchased_from.name }}" class="form-control selectpicker" data-live-search="true" data-sourceurl="{% url 'api_secure' model='supplier' %}">
         {% if object.purchased_from %}

assets/templates/supplier_list.html

@@ -14,7 +14,7 @@
     <div class="input-group pull-right" style="width: auto;">
         {% render_field form.query|add_class:'form-control' placeholder='Search by Name' style="width: 250px"%}
         <label for="query" class="sr-only">Name:</label>
-        <span class="input-group-btn"><button type="submit" class="btn btn-default">Search</button></span>
+        <span class="input-group-btn"><button type="submit" class="btn btn-default" id="id_search">Search</button></span>
     </div>
 </form>
 
@@ -27,8 +27,8 @@
   </thead>
   <tbody id="asset_table_body">
     {% for item in object_list %}
-    <tr>
-      <td>{{ item.name }}</td>
+    <tr class="supplierRow">
+      <td class="supplierName">{{ item.name }}</td>
       <td>
         <a href="{% url 'supplier_detail' item.pk %}" class="btn btn-default"><i class="glyphicon glyphicon-eye-open"></i> View</a>
         <a href="{% url 'supplier_update' item.pk %}" class="btn btn-default"><i class="glyphicon glyphicon-edit"></i> Edit</a>

assets/templates/supplier_update.html

@@ -13,8 +13,8 @@
     </div>
     <form method="post">
         {% csrf_token %}
-            {{ form }}
-
+        {% include 'form_errors.html' %}
+        {{ form }}
         <input type="submit" value="Save" class="btn btn-success">
     </form>
 {% endblock %}