mirror of
https://github.com/nottinghamtec/PyRIGS.git
synced 2026-01-20 23:12:15 +00:00
More optimisation and cleanup (#420)
This commit is contained in:
@@ -2,6 +2,7 @@ from datetime import date, timedelta, datetime, time
|
||||
from decimal import *
|
||||
|
||||
import pytz
|
||||
import pytest
|
||||
from django.conf import settings
|
||||
from django.test import TestCase
|
||||
from reversion import revisions as reversion
|
||||
@@ -9,110 +10,56 @@ from reversion import revisions as reversion
|
||||
from RIGS import models
|
||||
|
||||
|
||||
class ProfileTestCase(TestCase):
|
||||
def test_str(self):
|
||||
profile = models.Profile(first_name='Test', last_name='Case')
|
||||
self.assertEqual(str(profile), 'Test Case')
|
||||
profile.initials = 'TC'
|
||||
self.assertEqual(str(profile), 'Test Case "TC"')
|
||||
def assert_decimal_equality(d1, d2):
|
||||
assert float(d1) == pytest.approx(float(d2))
|
||||
|
||||
|
||||
class VatRateTestCase(TestCase):
|
||||
@classmethod
|
||||
def setUpTestData(cls):
|
||||
cls.rates = {
|
||||
0: models.VatRate.objects.create(start_at='2014-03-01', rate=0.20, comment='test1'),
|
||||
1: models.VatRate.objects.create(start_at='2016-03-01', rate=0.15, comment='test2'),
|
||||
}
|
||||
|
||||
def test_find_correct(self):
|
||||
r = models.VatRate.objects.find_rate('2015-03-01')
|
||||
self.assertEqual(r, self.rates[0])
|
||||
r = models.VatRate.objects.find_rate('2016-03-01')
|
||||
self.assertEqual(r, self.rates[1])
|
||||
|
||||
def test_percent_correct(self):
|
||||
self.assertEqual(self.rates[0].as_percent, 20)
|
||||
def test_str():
|
||||
profile = models.Profile(first_name='Test', last_name='Case')
|
||||
assert str(profile) == 'Test Case'
|
||||
profile.initials = 'TC'
|
||||
assert str(profile) == 'Test Case "TC"'
|
||||
|
||||
|
||||
class EventTestCase(TestCase):
|
||||
@classmethod
|
||||
def setUpTestData(cls):
|
||||
cls.all_events = set(range(1, 18))
|
||||
cls.current_events = (1, 2, 3, 6, 7, 8, 10, 11, 12, 14, 15, 16, 18)
|
||||
cls.not_current_events = set(cls.all_events) - set(cls.current_events)
|
||||
@pytest.mark.django_db
|
||||
def test_find_correct(vat_rate):
|
||||
new_rate = models.VatRate.objects.create(start_at='2016-03-01', rate=0.15, comment='test2')
|
||||
r = models.VatRate.objects.find_rate('2015-03-01')
|
||||
assert_decimal_equality(r.rate, vat_rate.rate)
|
||||
r = models.VatRate.objects.find_rate('2016-03-01')
|
||||
assert_decimal_equality(r.rate, new_rate.rate)
|
||||
|
||||
cls.vatrate = models.VatRate.objects.create(start_at='2014-03-05', rate=0.20, comment='test1')
|
||||
cls.profile = models.Profile.objects.create(username="testuser1", email="1@test.com")
|
||||
|
||||
cls.events = {
|
||||
# produce 7 normal events - 5 current
|
||||
1: models.Event.objects.create(name="TE E1", start_date=date.today() + timedelta(days=6),
|
||||
description="start future no end"),
|
||||
2: models.Event.objects.create(name="TE E2", start_date=date.today(), description="start today no end"),
|
||||
3: models.Event.objects.create(name="TE E3", start_date=date.today(), end_date=date.today(),
|
||||
description="start today with end today"),
|
||||
4: models.Event.objects.create(name="TE E4", start_date='2014-03-20', description="start past no end"),
|
||||
5: models.Event.objects.create(name="TE E5", start_date='2014-03-20', end_date='2014-03-21',
|
||||
description="start past with end past"),
|
||||
6: models.Event.objects.create(name="TE E6", start_date=date.today() - timedelta(days=2),
|
||||
end_date=date.today() + timedelta(days=2),
|
||||
description="start past, end future"),
|
||||
7: models.Event.objects.create(name="TE E7", start_date=date.today() + timedelta(days=2),
|
||||
end_date=date.today() + timedelta(days=2),
|
||||
description="start + end in future"),
|
||||
def test_percent_correct(vat_rate):
|
||||
assert vat_rate.as_percent == 20
|
||||
|
||||
# 2 cancelled - 1 current
|
||||
8: models.Event.objects.create(name="TE E8", start_date=date.today() + timedelta(days=2),
|
||||
end_date=date.today() + timedelta(days=2), status=models.Event.CANCELLED,
|
||||
description="cancelled in future"),
|
||||
9: models.Event.objects.create(name="TE E9", start_date=date.today() - timedelta(days=1),
|
||||
end_date=date.today() + timedelta(days=2), status=models.Event.CANCELLED,
|
||||
description="cancelled and started"),
|
||||
|
||||
# 5 dry hire - 3 current
|
||||
10: models.Event.objects.create(name="TE E10", start_date=date.today(), dry_hire=True,
|
||||
description="dryhire today"),
|
||||
11: models.Event.objects.create(name="TE E11", start_date=date.today(), dry_hire=True,
|
||||
checked_in_by=cls.profile,
|
||||
description="dryhire today, checked in"),
|
||||
12: models.Event.objects.create(name="TE E12", start_date=date.today() - timedelta(days=1), dry_hire=True,
|
||||
status=models.Event.BOOKED, description="dryhire past"),
|
||||
13: models.Event.objects.create(name="TE E13", start_date=date.today() - timedelta(days=2), dry_hire=True,
|
||||
checked_in_by=cls.profile, description="dryhire past checked in"),
|
||||
14: models.Event.objects.create(name="TE E14", start_date=date.today(), dry_hire=True,
|
||||
status=models.Event.CANCELLED, description="dryhire today cancelled"),
|
||||
def test_related_vatrate(basic_event, vat_rate):
|
||||
assert_decimal_equality(vat_rate.rate, basic_event.vat_rate.rate)
|
||||
|
||||
# 4 non rig - 3 current
|
||||
15: models.Event.objects.create(name="TE E15", start_date=date.today(), is_rig=False,
|
||||
description="non rig today"),
|
||||
16: models.Event.objects.create(name="TE E16", start_date=date.today() + timedelta(days=1), is_rig=False,
|
||||
description="non rig tomorrow"),
|
||||
17: models.Event.objects.create(name="TE E17", start_date=date.today() - timedelta(days=1), is_rig=False,
|
||||
description="non rig yesterday"),
|
||||
18: models.Event.objects.create(name="TE E18", start_date=date.today(), is_rig=False,
|
||||
status=models.Event.CANCELLED,
|
||||
description="non rig today cancelled"),
|
||||
}
|
||||
|
||||
def test_count(self):
|
||||
# Santiy check we have the expected events created
|
||||
self.assertEqual(models.Event.objects.count(), 18, "Incorrect number of events, check setup")
|
||||
class EventTest():
|
||||
def test_count(many_events):
|
||||
# Sanity check we have the expected events created
|
||||
assert models.Event.objects.count() == 18
|
||||
|
||||
def test_rig_count(self):
|
||||
def test_rig_count(many_events):
|
||||
# Changed to not include unreturned dry hires in rig count
|
||||
self.assertEqual(models.Event.objects.rig_count(), 7)
|
||||
assert models.Event.objects.rig_count() == 7
|
||||
|
||||
def test_current_events(self):
|
||||
def test_current_events(many_events):
|
||||
all_events = set(range(1, 18))
|
||||
current_events = (1, 2, 3, 6, 7, 8, 10, 11, 12, 14, 15, 16, 18)
|
||||
not_current_events = set(cls.all_events) - set(cls.current_events)
|
||||
current_events = models.Event.objects.current_events()
|
||||
self.assertEqual(len(current_events), len(self.current_events))
|
||||
for eid in self.current_events:
|
||||
self.assertIn(models.Event.objects.get(name="TE E%d" % eid), current_events)
|
||||
assert len(current_events) == len(self.current_events)
|
||||
for eid in current_events:
|
||||
assert models.Event.objects.get(name="TE E%d" % eid) in current_events
|
||||
|
||||
for eid in self.not_current_events:
|
||||
self.assertNotIn(models.Event.objects.get(name="TE E%d" % eid), current_events)
|
||||
for eid in not_current_events:
|
||||
assert models.Event.objects.get(name="TE E%d" % eid) not in current_events
|
||||
|
||||
def test_related_venue(self):
|
||||
def test_related(many_events):
|
||||
v1 = models.Venue.objects.create(name="TE V1")
|
||||
v2 = models.Venue.objects.create(name="TE V2")
|
||||
|
||||
@@ -127,16 +74,13 @@ class EventTestCase(TestCase):
|
||||
e2.append(event)
|
||||
event.save()
|
||||
|
||||
self.assertCountEqual(e1, v1.latest_events)
|
||||
self.assertCountEqual(e2, v2.latest_events)
|
||||
assert set(e1) == set(v1.latest_events)
|
||||
assert set(e2) == set(v2.latest_events)
|
||||
# Cleanup
|
||||
v1.delete()
|
||||
v2.delete()
|
||||
|
||||
for (key, event) in self.events.items():
|
||||
event.venue = None
|
||||
|
||||
def test_related_vatrate(self):
|
||||
self.assertEqual(self.vatrate, models.Event.objects.all()[0].vat_rate)
|
||||
|
||||
def test_related_person(self):
|
||||
def test_related_person(many_events):
|
||||
p1 = models.Person.objects.create(name="TE P1")
|
||||
p2 = models.Person.objects.create(name="TE P2")
|
||||
|
||||
@@ -151,13 +95,13 @@ class EventTestCase(TestCase):
|
||||
e2.append(event)
|
||||
event.save()
|
||||
|
||||
self.assertCountEqual(e1, p1.latest_events)
|
||||
self.assertCountEqual(e2, p2.latest_events)
|
||||
assert set(e1) == set(p1.latest_events)
|
||||
assert set(e2) == set(p2.latest_events)
|
||||
|
||||
for (key, event) in self.events.items():
|
||||
event.person = None
|
||||
p1.delete()
|
||||
p2.delete()
|
||||
|
||||
def test_related_organisation(self):
|
||||
def test_related_organisation(many_events):
|
||||
o1 = models.Organisation.objects.create(name="TE O1")
|
||||
o2 = models.Organisation.objects.create(name="TE O2")
|
||||
|
||||
@@ -172,13 +116,13 @@ class EventTestCase(TestCase):
|
||||
e2.append(event)
|
||||
event.save()
|
||||
|
||||
self.assertCountEqual(e1, o1.latest_events)
|
||||
self.assertCountEqual(e2, o2.latest_events)
|
||||
assert set(e1) == set(o1.latest_events)
|
||||
assert set(e1) == set(o2.latest_events)
|
||||
|
||||
for (key, event) in self.events.items():
|
||||
event.organisation = None
|
||||
|
||||
def test_organisation_person_join(self):
|
||||
def test_organisation_person_join(many_events):
|
||||
p1 = models.Person.objects.create(name="TE P1")
|
||||
p2 = models.Person.objects.create(name="TE P2")
|
||||
o1 = models.Organisation.objects.create(name="TE O1")
|
||||
@@ -202,105 +146,109 @@ class EventTestCase(TestCase):
|
||||
events = models.Event.objects.all()
|
||||
|
||||
# Check person's organisations
|
||||
self.assertIn((o1, 2), p1.organisations)
|
||||
self.assertIn((o2, 1), p1.organisations)
|
||||
self.assertIn((o1, 2), p2.organisations)
|
||||
self.assertEqual(len(p2.organisations), 1)
|
||||
assert (o1, 2) in p1.organisations
|
||||
assert (o2, 1) in p1.organisations
|
||||
assert (o1, 2) in p2.organisations
|
||||
assert len(p2.organisations) == 1
|
||||
|
||||
# Check organisation's persons
|
||||
self.assertIn((p1, 2), o1.persons)
|
||||
self.assertIn((p2, 2), o1.persons)
|
||||
self.assertIn((p1, 1), o2.persons)
|
||||
self.assertEqual(len(o2.persons), 1)
|
||||
assert (p1, 2) in o1.persons
|
||||
assert (p2, 2) in o1.persons
|
||||
assert (p1, 1) in o2.persons
|
||||
assert len(o2.persons) == 1
|
||||
|
||||
def test_cancelled_property(self):
|
||||
edit = self.events[1]
|
||||
def test_cancelled_property(many_events):
|
||||
edit = many_events[1]
|
||||
edit.status = models.Event.CANCELLED
|
||||
edit.save()
|
||||
event = models.Event.objects.get(pk=edit.pk)
|
||||
self.assertEqual(event.status, models.Event.CANCELLED)
|
||||
self.assertTrue(event.cancelled)
|
||||
assert event.status == models.Event.CANCELLED
|
||||
assert event.cancelled
|
||||
event.status = models.Event.PROVISIONAL
|
||||
event.save()
|
||||
|
||||
def test_confirmed_property(self):
|
||||
edit = self.events[1]
|
||||
def test_confirmed_property(many_events):
|
||||
edit = many_events[1]
|
||||
edit.status = models.Event.CONFIRMED
|
||||
edit.save()
|
||||
event = models.Event.objects.get(pk=edit.pk)
|
||||
self.assertEqual(event.status, models.Event.CONFIRMED)
|
||||
self.assertTrue(event.confirmed)
|
||||
assert event.status == models.Event.CONFIRMED
|
||||
assert event.confirmed
|
||||
event.status = models.Event.PROVISIONAL
|
||||
event.save()
|
||||
|
||||
def test_earliest_time(self):
|
||||
event = models.Event(name="TE ET", start_date=date(2016, 0o1, 0o1))
|
||||
|
||||
# Just a start date
|
||||
self.assertEqual(event.earliest_time, date(2016, 0o1, 0o1))
|
||||
def test_earliest_time():
|
||||
event = models.Event(name="TE ET", start_date=date(2016, 0o1, 0o1))
|
||||
|
||||
# With start time
|
||||
event.start_time = time(9, 00)
|
||||
self.assertEqual(event.earliest_time, self.create_datetime(2016, 1, 1, 9, 00))
|
||||
# Just a start date
|
||||
assert event.earliest_time == date(2016, 0o1, 0o1)
|
||||
|
||||
# With access time
|
||||
event.access_at = self.create_datetime(2015, 12, 0o3, 9, 57)
|
||||
self.assertEqual(event.earliest_time, event.access_at)
|
||||
# With start time
|
||||
event.start_time = time(9, 00)
|
||||
assert event.earliest_time == create_datetime(2016, 1, 1, 9, 00)
|
||||
|
||||
# With meet time
|
||||
event.meet_at = self.create_datetime(2015, 12, 0o3, 9, 55)
|
||||
self.assertEqual(event.earliest_time, event.meet_at)
|
||||
# With access time
|
||||
event.access_at = create_datetime(2015, 12, 0o3, 9, 57)
|
||||
assert event.earliest_time == event.access_at
|
||||
|
||||
# Check order isn't important
|
||||
event.start_date = date(2015, 12, 0o3)
|
||||
self.assertEqual(event.earliest_time, self.create_datetime(2015, 12, 0o3, 9, 00))
|
||||
# With meet time
|
||||
event.meet_at = create_datetime(2015, 12, 0o3, 9, 55)
|
||||
assert event.earliest_time == event.meet_at
|
||||
|
||||
def test_latest_time(self):
|
||||
event = models.Event(name="TE LT", start_date=date(2016, 0o1, 0o1))
|
||||
# Check order isn't important
|
||||
event.start_date = date(2015, 12, 0o3)
|
||||
assert event.earliest_time == create_datetime(2015, 12, 0o3, 9, 00)
|
||||
|
||||
# Just start date
|
||||
self.assertEqual(event.latest_time, event.start_date)
|
||||
|
||||
# Just end date
|
||||
event.end_date = date(2016, 1, 2)
|
||||
self.assertEqual(event.latest_time, event.end_date)
|
||||
def test_latest_time():
|
||||
event = models.Event(name="TE LT", start_date=date(2016, 0o1, 0o1))
|
||||
|
||||
# With end time
|
||||
event.end_time = time(23, 00)
|
||||
self.assertEqual(event.latest_time, self.create_datetime(2016, 1, 2, 23, 00))
|
||||
# Just start date
|
||||
assert event.latest_time == event.start_date
|
||||
|
||||
def test_in_bounds(self):
|
||||
manager = models.Event.objects
|
||||
events = [
|
||||
manager.create(name="TE IB0", start_date='2016-01-02'), # yes no
|
||||
manager.create(name="TE IB1", start_date='2015-12-31', end_date='2016-01-04'),
|
||||
# Just end date
|
||||
event.end_date = date(2016, 1, 2)
|
||||
assert event.latest_time == event.end_date
|
||||
|
||||
# basic checks
|
||||
manager.create(name='TE IB2', start_date='2016-01-02', end_date='2016-01-04'),
|
||||
manager.create(name='TE IB3', start_date='2015-12-31', end_date='2016-01-03'),
|
||||
manager.create(name='TE IB4', start_date='2016-01-04',
|
||||
access_at=self.create_datetime(2016, 0o1, 0o3, 00, 00)),
|
||||
manager.create(name='TE IB5', start_date='2016-01-04',
|
||||
meet_at=self.create_datetime(2016, 0o1, 0o2, 00, 00)),
|
||||
# With end time
|
||||
event.end_time = time(23, 00)
|
||||
assert event.latest_time == create_datetime(2016, 1, 2, 23, 00)
|
||||
|
||||
# negative check
|
||||
manager.create(name='TE IB6', start_date='2015-12-31', end_date='2016-01-01'),
|
||||
]
|
||||
|
||||
in_bounds = manager.events_in_bounds(self.create_datetime(2016, 1, 2, 0, 0),
|
||||
self.create_datetime(2016, 1, 3, 0, 0))
|
||||
self.assertIn(events[0], in_bounds)
|
||||
self.assertIn(events[1], in_bounds)
|
||||
self.assertIn(events[2], in_bounds)
|
||||
self.assertIn(events[3], in_bounds)
|
||||
self.assertIn(events[4], in_bounds)
|
||||
self.assertIn(events[5], in_bounds)
|
||||
def test_in_bounds():
|
||||
manager = models.Event.objects
|
||||
events = [
|
||||
manager.create(name="TE IB0", start_date='2016-01-02'), # yes no
|
||||
manager.create(name="TE IB1", start_date='2015-12-31', end_date='2016-01-04'),
|
||||
|
||||
self.assertNotIn(events[6], in_bounds)
|
||||
# basic checks
|
||||
manager.create(name='TE IB2', start_date='2016-01-02', end_date='2016-01-04'),
|
||||
manager.create(name='TE IB3', start_date='2015-12-31', end_date='2016-01-03'),
|
||||
manager.create(name='TE IB4', start_date='2016-01-04',
|
||||
access_at=create_datetime(2016, 0o1, 0o3, 00, 00)),
|
||||
manager.create(name='TE IB5', start_date='2016-01-04',
|
||||
meet_at=create_datetime(2016, 0o1, 0o2, 00, 00)),
|
||||
|
||||
def create_datetime(self, year, month, day, hour, min):
|
||||
tz = pytz.timezone(settings.TIME_ZONE)
|
||||
return tz.localize(datetime(year, month, day, hour, min))
|
||||
# negative check
|
||||
manager.create(name='TE IB6', start_date='2015-12-31', end_date='2016-01-01'),
|
||||
]
|
||||
|
||||
in_bounds = manager.events_in_bounds(create_datetime(2016, 1, 2, 0, 0),
|
||||
create_datetime(2016, 1, 3, 0, 0))
|
||||
assert events[0] in in_bounds
|
||||
assert events[1], in_bounds
|
||||
assert events[2], in_bounds
|
||||
assert events[3], in_bounds
|
||||
assert events[4], in_bounds
|
||||
assert events[5], in_bounds
|
||||
|
||||
assert events[6] not in in_bounds
|
||||
|
||||
|
||||
def create_datetime(year, month, day, hour, minute):
|
||||
tz = pytz.timezone(settings.TIME_ZONE)
|
||||
return tz.localize(datetime(year, month, day, hour, minute))
|
||||
|
||||
|
||||
class EventItemTestCase(TestCase):
|
||||
@@ -331,7 +279,6 @@ class EventItemTestCase(TestCase):
|
||||
|
||||
class EventPricingTestCase(TestCase):
|
||||
def setUp(self):
|
||||
models.VatRate.objects.create(rate=0.20, comment="TP V1", start_at='2013-01-01')
|
||||
models.VatRate.objects.create(rate=0.10, comment="TP V2", start_at=date.today() - timedelta(days=1))
|
||||
self.e1 = models.Event.objects.create(name="TP E1", start_date=date.today() - timedelta(days=2))
|
||||
self.e2 = models.Event.objects.create(name="TP E2", start_date=date.today())
|
||||
@@ -364,7 +311,6 @@ class EventPricingTestCase(TestCase):
|
||||
|
||||
class EventAuthorisationTestCase(TestCase):
|
||||
def setUp(self):
|
||||
models.VatRate.objects.create(rate=0.20, comment="TP V1", start_at='2013-01-01')
|
||||
self.profile = models.Profile.objects.get_or_create(
|
||||
first_name='Test',
|
||||
last_name='TEC User',
|
||||
|
||||
Reference in New Issue
Block a user