arona/PyRIGS
1
0
Fork 0
mirror of https://github.com/nottinghamtec/PyRIGS.git synced 2026-02-27 08:38:24 +00:00
Code Issues Projects Releases Wiki Activity

Fix has_required_levels logic being backward

Browse Source
This commit is contained in:
FreneticScribbler
2022-01-03 15:31:54 +00:00
parent 3e8cfe4f11
commit 6b19d0e8b8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
training/models.py
View File

@@ -202,7 +202,8 @@ class TrainingLevel(models.Model, RevisionMixin):
def user_has_requirements(self, user): def user_has_requirements(self, user):
has_required_items = all(TrainingItem.user_has_qualification(req.item, user, req.depth) for req in self.requirements.all()) has_required_items = all(TrainingItem.user_has_qualification(req.item, user, req.depth) for req in self.requirements.all())
has_required_levels = not self.prerequisite_levels.all().exists() or set(user.level_qualifications.values_list('level', flat=True)).issubset(set(self.prerequisite_levels.all())) # Always true if there are no prerequisites, otherwise get a set of prerequsite IDs and check if they are a subset of the set of qualification IDs
has_required_levels = not self.prerequisite_levels.all().exists() or set(self.prerequisite_levels.values_list('pk', flat=True)).issubset(set(user.level_qualifications.values_list('level', flat=True)))
return has_required_items and has_required_levels return has_required_items and has_required_levels
def __str__(self): def __str__(self):