arona/PyRIGS
1
0
Fork 0
mirror of https://github.com/nottinghamtec/PyRIGS.git synced 2026-01-23 16:32:15 +00:00
Code Issues Projects Releases Wiki Activity

Reverted to using Django ORM for the calculation of event totals and payment totals on an invoice.

Browse Source 
Need to pay closer attention to the docs which state that the SUM(arg[0], fields) arg[0] is the returned type.
This commit is contained in:
root
2015-03-03 17:29:38 +00:00
parent bab8b98db3
commit 4247351253
1 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
RIGS/models.py
View File

@@ -7,6 +7,7 @@ from django.conf import settings
from django.utils.functional import cached_property from django.utils.functional import cached_property
import reversion import reversion
from decimal import Decimal
# Create your models here. # Create your models here.
class Profile(AbstractUser): class Profile(AbstractUser):
@@ -248,14 +249,20 @@ class Event(models.Model, RevisionMixin):
@property @property
def sum_total(self): def sum_total(self):
# Manual querying is required for efficiency whilst maintaining floating point arithmetic # Manual querying is required for efficiency whilst maintaining floating point arithmetic
if connection.vendor == 'postgresql': # if connection.vendor == 'postgresql':
sql = "SELECT SUM(quantity * cost) AS sum_total FROM \"RIGS_eventitem\" WHERE event_id=%i" % self.id # sql = "SELECT SUM(quantity * cost) AS sum_total FROM \"RIGS_eventitem\" WHERE event_id=%i" % self.id
else: # else:
sql = "SELECT id, SUM(quantity * cost) AS sum_total FROM RIGS_eventitem WHERE event_id=%i" % self.id # sql = "SELECT id, SUM(quantity * cost) AS sum_total FROM RIGS_eventitem WHERE event_id=%i" % self.id
total = self.items.raw(sql)[0] #total = self.items.raw(sql)[0]
if total.sum_total: #if total.sum_total:
return total.sum_total # return total.sum_total
return 0.0 #total = 0.0
#for item in self.items.filter(cost__gt=0).extra(select="SUM(cost * quantity) AS sum"):
# total += item.sum
total = EventItem.objects.filter(event=self, cost__gt=0).aggregate(sum_total=models.Sum('cost',field="quantity * cost"))['sum_total']
if total:
return total
return Decimal("0.00")
@cached_property @cached_property
def vat_rate(self): def vat_rate(self):
@@ -335,18 +342,22 @@ class Invoice(models.Model):
@property @property
def payment_total(self): def payment_total(self):
# Manual querying is required for efficiency whilst maintaining floating point arithmetic # Manual querying is required for efficiency whilst maintaining floating point arithmetic
if connection.vendor == 'postgresql': #if connection.vendor == 'postgresql':
sql = "SELECT SUM(amount) AS total FROM \"RIGS_payment\" WHERE invoice_id=%i" % self.id # sql = "SELECT SUM(amount) AS total FROM \"RIGS_payment\" WHERE invoice_id=%i" % self.id
else: #else:
sql = "SELECT id, SUM(amount) AS total FROM RIGS_payment WHERE invoice_id=%i" % self.id # sql = "SELECT id, SUM(amount) AS total FROM RIGS_payment WHERE invoice_id=%i" % self.id
total = self.payment_set.raw(sql)[0] #total = self.payment_set.raw(sql)[0]
if total.total: #if total.total:
return total.total # return total.total
return 0.0 #return 0.0
total = self.payment_set.aggregate(total=models.Sum('amount'))['total']
if total:
return total
return Decimal("0.00")
@property @property
def balance(self): def balance(self):
return float(self.sum_total) - float(self.payment_total) return self.sum_total - self.payment_total
def __str__(self): def __str__(self):
return "%i: %s (%.2f)" % (self.pk, self.event, self.balance) return "%i: %s (%.2f)" % (self.pk, self.event, self.balance)