From 3123d3899c5b27922595f7b75df9ef461114b91b Mon Sep 17 00:00:00 2001 From: FreneticScribbler Date: Sun, 21 Jul 2024 16:38:09 +0100 Subject: [PATCH] Fix regression in autocompleter - when adding new people/orgs/venues through modal they are not autoselected Ah the lovely fragile javascript ecosystem, I can't even pin down when or why it broke. --- pipeline/source_assets/js/autocompleter.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pipeline/source_assets/js/autocompleter.js b/pipeline/source_assets/js/autocompleter.js index 1f8ea909..97696774 100644 --- a/pipeline/source_assets/js/autocompleter.js +++ b/pipeline/source_assets/js/autocompleter.js @@ -1,16 +1,11 @@ function changeSelectedValue(obj,pk,text,update_url) { //Pass in JQuery object and new parameters //console.log('Changing selected value'); obj.find('option').remove(); //Remove all the available options - obj.append( //Add the new option - $("") - .attr("value",pk) - .text(text) - .data('update_url',update_url) - ); - obj.selectpicker('render'); //Re-render the UI - obj.selectpicker('refresh'); //Re-render the UI - obj.selectpicker('val', pk); //Set the new value to be selected + obj[0].add(new Option(text, pk, true, true)); // Add new option + //obj.selectpicker('val', pk); //Set the new value to be selected + obj.selectpicker('refresh'); obj.change(); //Trigger the change function manually + //console.log(obj); } function refreshUpdateHref(obj) {