Re-do fix for #537 without regression

Ignore versions for "None" models, such as where the model has subsequently been deleted (eventchecklistcrew and eventchecklistvehicle). Now it makes sense...
This commit is contained in:
2023-06-28 13:39:10 +01:00
parent 677f352524
commit 1ce6ec3284

View File

@@ -160,15 +160,15 @@ class ModelComparison:
# Build some dicts of what we have
item_dict = {} # build a list of items, key is the item_pk
if len(new_item_versions) == 0:
return None
for version in old_item_versions: # put all the old versions in a list
if version is None or version.object is None:
if version._model is None:
continue
compare = ModelComparison(old=version._object_version.object, **comparisonParams)
item_dict[version.object_id] = compare
for version in new_item_versions: # go through the new versions
if version._model is None:
continue
try:
compare = item_dict[version.object_id] # see if there's a matching old version
compare.new = version._object_version.object # then add the new version to the dictionary